Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BiDi support #1033

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: BiDi support #1033

merged 2 commits into from
Jan 17, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 17, 2025 •
edited
Loading

☑️ Resolves

  • Add BiDi support, including:
    • Setting dir based on language
    • Correctly handle RTL in title bar (CSS env if always LTR X position)

Note for reviewers: since Talk Desktop only uses system language, for testing you can change it in

talk-desktop/src/shared/setupWebPage.js

Line 57 in 7227939

const { language, locale } = appData.userMetadata ?? await window.TALK_DESKTOP.getSystemL10n()

🖼️ Screenshots

image

@ShGKme ShGKme added bug Something isn't working 3. to review labels Jan 17, 2025
@ShGKme ShGKme requested a review from DorraJaouad January 17, 2025 12:45
@ShGKme ShGKme self-assigned this Jan 17, 2025
@ShGKme ShGKme added this to the 🌠 Next Patch milestone Jan 17, 2025
DorraJaouad
DorraJaouad approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

ShGKme added 2 commits January 17, 2025 21:48
@ShGKme
fix: add bidi support
9345ede 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
fix(titlebar): support BiDi
897c347 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme merged commit bc45179 into main Jan 17, 2025
10 checks passed
@ShGKme ShGKme deleted the fix/bidi branch January 17, 2025 20:52
This was referenced Jan 20, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @DorraJaouad