Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert copyright headers to SPDX format #656

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 8, 2024

No description provided.

@ShGKme ShGKme added 3. to review technical debt Maintenance and refactoring labels May 8, 2024
@ShGKme ShGKme requested a review from nickvergessen May 8, 2024 12:50
@ShGKme ShGKme self-assigned this May 8, 2024
.reuse/dep5 Outdated
Comment on lines 41 to 43
# Nextcloud server styles and assets, generated by the server
Files: src/shared/assets/default/**/*
Copyright: Nextcloud GmbH and Nextcloud contributors
License: AGPL-3.0-or-later
Copy link
Contributor Author

@ShGKme ShGKme May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is correct. Those are styles generated by the server + from the server source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen Question about license is still actual here 👀

@ShGKme ShGKme force-pushed the chore/licenses branch from 8303aee to 25e2754 Compare May 8, 2024 17:44
@nickvergessen
Copy link
Member

The following files have no copyright and licensing information:
* .eslintignore
* .github/dependabot.yml
* .github/pull_request_template.md
* img/talk-icon-mac-shadow.svg
* img/talk-icon-mac.svg
* img/talk-icon-plain-dark.svg
* img/talk-icon-plain-light.svg
* img/talk-icon-rounded.svg
* img/talk-icon-square.svg
* src/shared/assets/default/close.svg
* src/shared/assets/default/icons.css
* src/shared/assets/default/server.css

@ShGKme
Copy link
Contributor Author

ShGKme commented May 10, 2024

The following files have no copyright and licensing information:

  • .eslintignore

Suddenly missed in .reuse/dep5. Fixed.

  • .github/dependabot.yml
  • .github/pull_request_template.md

.reuse/dep5:

# CI
Files: .github/**/*
Copyright: none
License: CC0-1.0

Syntax is not correct?

  • img/talk-icon-mac-shadow.svg
  • img/talk-icon-mac.svg
  • img/talk-icon-plain-dark.svg
  • img/talk-icon-plain-light.svg
  • img/talk-icon-rounded.svg
  • img/talk-icon-square.svg

Same

# Nextcloud marks
Files: img/**/*
Copyright: Nextcloud GmbH <https://nextcloud.com/trademarks/>
License: LicenseRef-NextcloudTrademarks
  • src/shared/assets/default/close.svg
  • src/shared/assets/default/icons.css
  • src/shared/assets/default/server.css

Same:

# Nextcloud server styles and assets, generated by the server
Files: src/shared/assets/default/**/*
Copyright: Nextcloud GmbH and Nextcloud contributors
License: AGPL-3.0-or-later

@nickvergessen
Copy link
Member

Syntax is not correct?

X/**/* does not match files inside X

I'll send a follow up commit

Signed-off-by: Grigorii K. Shartsev <[email protected]>

fixup! chore: convert copyright headers to SPDX format

Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme and others added 2 commits May 13, 2024 11:03
Signed-off-by: Grigorii K. Shartsev <[email protected]>

chore: Fix some missing licenses

Signed-off-by: Joas Schilling <[email protected]>

chore: Improve reuse handling

Signed-off-by: Joas Schilling <[email protected]>

chore: Let's be more specific in case new imgs are added at some point

Signed-off-by: Joas Schilling <[email protected]>

squash! set SPDX header in config files instead of reuse

Signed-off-by: Grigorii K. Shartsev <[email protected]>

Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@ShGKme
Copy link
Contributor Author

ShGKme commented May 13, 2024

Squashed, rebased onto main

@ShGKme ShGKme enabled auto-merge May 13, 2024 09:04
@ShGKme ShGKme disabled auto-merge May 13, 2024 09:04
@ShGKme ShGKme enabled auto-merge May 13, 2024 09:04
@ShGKme ShGKme merged commit 8a38a13 into main May 13, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/licenses branch May 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review technical debt Maintenance and refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants