Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UserMenu): minor visual issues #737

Merged
merged 5 commits into from
Aug 6, 2024
Merged

fix(UserMenu): minor visual issues #737

merged 5 commits into from
Aug 6, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 2, 2024 •
edited
Loading

☑️ Resolves

  • There was a focusable element inside another focusable element
    • Some server global styles from button also have high specificity
    • Made avatar a button instead of wrapping into HTML button
    • Opens manually now, because floating vue doesn't support role=button as buttons
  • Submenu is kept open after reopening the user menu
    • Closed
  • Menu has unlimit width
    • Limited
  • Server icon is not a square
    • Adjusted size
  • Title bar has server specificfocus-visible underline
    • Removed

🖼️ Screenshots

🏚️ Before (2 focus) 🏡 After (1 focus)
image image
image .
🏚️ Before 🏡 After
image image
before after
image image
image image

@ShGKme ShGKme added bug Something isn't working 3. to review labels Aug 2, 2024
@ShGKme ShGKme requested review from DorraJaouad and Antreesy August 2, 2024 21:50
@ShGKme ShGKme self-assigned this Aug 2, 2024
@ShGKme ShGKme changed the title fix(talk): slightly adjust user menu button styles fix(talk): slightly adjust user menu Aug 2, 2024
@ShGKme ShGKme marked this pull request as draft August 2, 2024 22:43
@ShGKme ShGKme force-pushed the fix/minor-title-bar-adjustments branch from acddcc9 to a6f6ad5 Compare August 3, 2024 15:13
@ShGKme ShGKme marked this pull request as ready for review August 3, 2024 15:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 3, 2024

Adding one more small change

@ShGKme ShGKme force-pushed the fix/minor-title-bar-adjustments branch from a6f6ad5 to baf0cdf Compare August 3, 2024 16:04
@ShGKme ShGKme changed the title fix(talk): slightly adjust user menu fix(UserMenu): minor visual issues Aug 3, 2024
@ShGKme ShGKme mentioned this pull request Aug 3, 2024
Merged
Antreesy
Antreesy approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

There is one ::after element on MainMenu could be removed
image

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 6, 2024

There is one ::after element on MainMenu could be removed

Fixed

@ShGKme ShGKme requested a review from Antreesy August 6, 2024 13:51
@ShGKme ShGKme force-pushed the fix/minor-title-bar-adjustments branch from eab6acb to 8b8ea8b Compare August 6, 2024 14:03
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 6, 2024

Rebased onto main

@ShGKme ShGKme enabled auto-merge August 6, 2024 14:04
@ShGKme ShGKme merged commit ba0488c into main Aug 6, 2024
6 checks passed
@ShGKme ShGKme deleted the fix/minor-title-bar-adjustments branch August 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy