Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patchers): ignore unset baseURL in @nextcloud/router #742

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 3, 2024

☑️ Resolves

  • Talk Desktop defines the default value for baseUrl in @nextcloud/router requests, it is it not explicitly set
  • But if it's set as undefined or other falsy value, Nextcloud Talk keeps it as a set value
  • It results in requesting without baseURL
  • Solution: only set baseURL if it is not actually set with truthy value

Example of the problematic place:
https://github.com/nextcloud/spreed/blob/29af6dac6325af9bba16b4706bb09066b601165e/src/utils/signaling.js#L980-L981

@ShGKme ShGKme added bug Something isn't working 3. to review labels Aug 3, 2024
@ShGKme ShGKme requested review from DorraJaouad and Antreesy August 3, 2024 21:23
@ShGKme ShGKme self-assigned this Aug 3, 2024
@ShGKme ShGKme mentioned this pull request Aug 3, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And signaling is back working!

@ShGKme ShGKme merged commit 2ac3466 into main Aug 5, 2024
6 checks passed
@ShGKme ShGKme deleted the fix/patchers--nextcloud-router--ignore-undefined-baseurl branch August 5, 2024 07:22
@ShGKme ShGKme mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants