fix(patchers): ignore unset baseURL in @nextcloud/router #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
baseUrl
in@nextcloud/router
requests, it is it not explicitly setundefined
or otherfalsy
value, Nextcloud Talk keeps it as a set valuebaseURL
baseURL
if it is not actually set withtruthy
valueExample of the problematic place:
https://github.com/nextcloud/spreed/blob/29af6dac6325af9bba16b4706bb09066b601165e/src/utils/signaling.js#L980-L981