-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(viewer): improve styling and loading/error handling #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Required to prepare packages (`@nextcloud/router`) used in `@nextcloud/files` Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
DorraJaouad
reviewed
Sep 4, 2024
Antreesy
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and smooth now =)
Thanks @DorraJaouad and @Antreesy, I forgot to test on the light theme 🌕 Fixed, see the last commit |
DorraJaouad
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 🦅 🦅
Antreesy
approved these changes
Sep 4, 2024
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Squashed |
43068be
to
5348be3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🚧 Tasks
@nextcloud/files
with@nextcloud/router
because it uses router on module init, which is not ready until Talk Desktop is readyNcModal
styles in fullscreen has hardcoded position and it wasn't correctly changed to support window title bar🖼️ Screenshots
Notes about loading
On fast connection there is no spinner to not blink. It only appears after
--animation-slow
delay.Video is also shown once it's ready to be played.