Skip to content

Stop video when media viewer disappears#2037

Merged
Ivansss merged 18 commits intomasterfrom
fix/noid/fix-video-stopping
Apr 24, 2025
Merged

Stop video when media viewer disappears#2037
Ivansss merged 18 commits intomasterfrom
fix/noid/fix-video-stopping

Conversation

@SystemKeeper
Copy link
Collaborator

@SystemKeeper SystemKeeper commented Mar 29, 2025

  • Fix race condition between showing preview in ShareViewController and allowing to hit the send button
  • Actually fix the video issue...
  • Open a video file in media viewer and start playing
  • Move to another image/video or close the media viewer

The original video keeps playing, with this PR it correctly pauses/stops.

@SystemKeeper SystemKeeper force-pushed the fix/noid/fix-video-stopping branch from 307562c to 667f205 Compare March 29, 2025 23:26
Base automatically changed from feat/1986/event-conversations to master April 4, 2025 16:01
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper SystemKeeper force-pushed the fix/noid/fix-video-stopping branch from f08ac6f to 39f6220 Compare April 19, 2025 19:56
@SystemKeeper SystemKeeper changed the title Fix/noid/fix video stopping Stop video when media viewer disappears Apr 19, 2025
@SystemKeeper SystemKeeper requested a review from Ivansss April 19, 2025 20:17
@SystemKeeper SystemKeeper marked this pull request as ready for review April 19, 2025 20:17
@Ivansss
Copy link
Member

Ivansss commented Apr 24, 2025

/backport to stable21

@Ivansss Ivansss merged commit ddc5a9a into master Apr 24, 2025
10 checks passed
@Ivansss Ivansss deleted the fix/noid/fix-video-stopping branch April 24, 2025 10:16
@SystemKeeper
Copy link
Collaborator Author

/backport 39f6220 to stable21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants