chore: remove unused npm dependencies #2763
Draft
+2
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Linskeseder <[email protected]>
jaylinski
commented
Jan 17, 2025
| @@ -83,7 +82,7 @@ export default class Task { | |||
|
|
|||
| if (!this.vtodo.hasProperty('uid')) { | |||
| console.debug('This task did not have a proper uid. Setting a new one for ', this) | |||
| this.vtodo.addPropertyWithValue('uid', uuid()) | |||
| this.vtodo.addPropertyWithValue('uid', crypto.randomUUID()) | |||
There was a problem hiding this comment.
This function is supported by all Nextcloud-supported browsers:
jaylinski
commented
Jan 17, 2025
| "sortablejs-vue3": "^1.2.11", | ||
| "uuid": "^11.0.5", |
There was a problem hiding this comment.
@nextcloud/[email protected]. It has to be removed there first before we can remove it here.
jaylinski
commented
Jan 17, 2025
| @@ -27,7 +27,6 @@ | |||
| "bugs": "https://github.com/nextcloud/tasks/issues", | |||
| "contributors": [], | |||
| "dependencies": { | |||
| "@nextcloud/auth": "^2.4.0", | |||
There was a problem hiding this comment.
This is a direct dependency of @nextcloud/axios.
jaylinski
commented
Jan 17, 2025
| @@ -43,15 +42,12 @@ | |||
| "color-convert": "^2.0.1", | |||
| "debounce": "^2.2.0", | |||
| "ical.js": "^2.1.0", | |||
| "linkify-it": "^5.0.0", | |||
There was a problem hiding this comment.
This is a direct dependency of markdown-it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npm run buildthe size of the JS output stays the same.The
npm cicommand is now about 0.5 to 1.0 seconds faster.