refactor(session):remove dup queries,refactorcode #5773
Conversation
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
Signed-off-by: Hoang Pham <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
First of all... I am sorry for taking so long to review this @hweihwang . I needed some quite time that really allowed me to focus on it.
I appreciate your contribution 🎉 .
| $documentId = $this->getDocumentId(); | ||
| $this->document = $this->documentService->getDocument($documentId); |
There was a problem hiding this comment.
This always runs - even if non of the Require... attributes were set.
Before we'd only get the document if any of the attributes was there.
Is this intentional?
I don't think it matters in practice as I assume all ISessionAwareControllers require at least one of them. Just want to point out a change in behavior that i am seeing here.
📝 Summary
🏁 Checklist