Skip to content

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Nov 7, 2025

Extracted from #7621

  • split setOnline and setOffline
  • add offline fixture to playwright
  • get request token from /csrftoken
  • split request token fixture from random user
  • cleanup unused type and context
  • mimetype change in playwright
  • basic editor page object model
  • file class for handling uploaded file
  • file.open()
  • with file.move() and file.close()
  • with editor.typeHeading()
  • change mimetype both ways
  • store test-results folder as artifacts
  • move File class to separate file
  • use EditorSection in offline test
  • chore(test) .withOpenMenu() to access submenus
  • write offline and come back online
  • reduce nesting in offline test
  • wait for close request when closing

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner November 7, 2025 19:05
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.96%. Comparing base (9d98aab) to head (46dde73).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7895   +/-   ##
=======================================
  Coverage   45.96%   45.96%           
=======================================
  Files         141      141           
  Lines        3964     3964           
  Branches      747      747           
=======================================
  Hits         1822     1822           
  Misses       1838     1838           
  Partials      304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@max-nextcloud max-nextcloud force-pushed the chore/tweak-playwright-tests branch from 95f9043 to 46dde73 Compare November 7, 2025 19:10
@max-nextcloud max-nextcloud requested review from a team and juliusknorr November 8, 2025 10:59
@benjaminfrueh benjaminfrueh self-requested a review November 8, 2025 14:19
@max-nextcloud max-nextcloud merged commit 9cfa326 into main Nov 8, 2025
68 checks passed
@max-nextcloud max-nextcloud deleted the chore/tweak-playwright-tests branch November 8, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants