feat: Propagate exception from saml library to our logs#1089
Open
CarlSchwan wants to merge 1 commit intomasterfrom
Open
feat: Propagate exception from saml library to our logs#1089CarlSchwan wants to merge 1 commit intomasterfrom
CarlSchwan wants to merge 1 commit intomasterfrom
Conversation
|
|
||
| if (count($errors) > 1) { | ||
| for ($i = 1; $i < count($errors); $i++) { | ||
| $this->logger->error('Got additional SAML error code: ' . $errors[0]); |
There was a problem hiding this comment.
should it not be $errors[$i] instead of $errors[0]?
artonge
reviewed
Apr 29, 2026
And make sure that we also log errors when processing SLO requests. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/backtrace-logs
branch
from
a282117 to
b83f7b0
Compare
artonge
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make sure that we also log errors when processing SLO requests.