MusicXmlViewer extension for sheet music #2752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Giesinger <[email protected]>
Signed-off-by: Benjamin Giesinger <[email protected]>
Signed-off-by: Benjamin Giesinger <[email protected]>
bneumann
force-pushed
the
feat/musicXmlViewer
branch
from
18a7bc6 to
4cdd9fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a propsal on how to integrate *.mxl and *.musicxml files in the viewer. It fixes #424
It works fairly well although the MIME type is not correct the sheets I tested. My guess is that Nextcloud symply uses
application/octed-streamfor any unknown binary file. And since the viewer relies on the MIME type I needed to filter on the extnesion as well.Please let me know if there is a better solution. Other then that, here you have it. Sheet music in your nextcloud :)