deprecate pihole install script #2730

szaimen · 2025-02-27T21:39:40Z

The pi-hole script is unfortunately deprecated as it needs a rewrite since many parts in the upstream pi-hole project changed.
Feel free to subscribe to szaimen/Nextcloud-NAS-Guide#133 in the meantime.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 55 in c1a2f5c

if ! yesno_box_no "Do you want to continue nonetheless?"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 57 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 61 in c1a2f5c

INSTALLED=$(grep "Pi-hole installed programs=" "$SCRIPTS/pihole-update.sh")

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 61 in c1a2f5c

INSTALLED=$(grep "Pi-hole installed programs=" "$SCRIPTS/pihole-update.sh")

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 62 in c1a2f5c

INSTALLED="${INSTALLED##*programs=}"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 65 in c1a2f5c

    
           if ! yesno_box_yes "These are all packets that where installed during your initial Pi-hole installation:

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 65 in c1a2f5c

    
           if ! yesno_box_yes "These are all packets that where installed during your initial Pi-hole installation:

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 71 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 83 in c1a2f5c

msg_box "It seems like some uninstall functions changed.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 85 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 89 in c1a2f5c

    
           check_command cp "/etc/.pihole/automated install/uninstall.sh" "$SCRIPTS"/pihole-uninstall.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 90 in c1a2f5c

    
           check_command sed -i '/######### SCRIPT ###########/q' "$SCRIPTS"/pihole-uninstall.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 91 in c1a2f5c

check_command echo "removeNoPurge" >> "$SCRIPTS"/pihole-uninstall.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 94 in c1a2f5c

check_command yes | bash "$SCRIPTS"/pihole-uninstall.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 97 in c1a2f5c

crontab -u root -l | grep -v "pihole-update.sh" | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 98 in c1a2f5c

check_command rm "$SCRIPTS"/pihole-uninstall.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 101 in c1a2f5c

if id pihole &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 101 in c1a2f5c

if id pihole &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 103 in c1a2f5c

check_command killall -u pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 104 in c1a2f5c

check_command deluser pihole &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 105 in c1a2f5c

check_command groupdel pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 109 in c1a2f5c

rm -rf /etc/.pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 110 in c1a2f5c

rm -rf /etc/pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 111 in c1a2f5c

rm -rf /opt/pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 112 in c1a2f5c

rm -rf /usr/bin/pihole-FTL

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 113 in c1a2f5c

rm -rf /usr/local/bin/pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 114 in c1a2f5c

rm -rf /var/www/html/admin

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 115 in c1a2f5c

rm -f /var/www/html/pihole

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 118 in c1a2f5c

crontab -u root -l | grep -v "systemctl restart unbound" | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 119 in c1a2f5c

rm /etc/unbound/unbound.conf.d/pi-hole.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 122 in c1a2f5c

rm -f "$SCRIPTS/pihole-update.sh"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 125 in c1a2f5c

for program in "${INSTALLED[@]}"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 127 in c1a2f5c

apt-get purge "$program" -y

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 131 in c1a2f5c

if is_this_installed unbound

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 131 in c1a2f5c

if is_this_installed unbound

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 133 in c1a2f5c

apt-get purge unbound -y

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 137 in c1a2f5c

apt-get autoremove -y

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 140 in c1a2f5c

rm -f /var/www/html/index.lighttpd.orig

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 141 in c1a2f5c

rm -rf /etc/lighttpd

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 144 in c1a2f5c

a2dissite pihole.conf &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 145 in c1a2f5c

rm -f "$SITES_AVAILABLE/pihole.conf"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 146 in c1a2f5c

restart_webserver

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 149 in c1a2f5c

ufw delete allow 53/tcp &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 150 in c1a2f5c

ufw delete allow 53/udp &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 151 in c1a2f5c

ufw delete allow 8094/tcp &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 154 in c1a2f5c

msg_box "Pi-hole was successfully uninstalled!

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 156 in c1a2f5c

msg_box "After you hit OK, your NcVM will get restarted."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 157 in c1a2f5c

rm -f "$SCRIPTS/pi-hole.sh"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 159 in c1a2f5c

reboot

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 163 in c1a2f5c

    
           msg_box "Before installing the Pi-hole, please make sure that you have a backup of your NcVM.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 168 in c1a2f5c

if ! yesno_box_no "Have you made a backup of your NcVM?

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 168 in c1a2f5c

if ! yesno_box_no "Have you made a backup of your NcVM?

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 172 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 176 in c1a2f5c

print_text_in_color "$ICyan" "Installing Pi-hole..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 179 in c1a2f5c

mkdir -p "$SCRIPTS"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 180 in c1a2f5c

    
           check_command curl -sfL https://install.pi-hole.net  -o "$SCRIPTS"/pihole-install.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 183 in c1a2f5c

    
           if ! grep -q 'displayFinalMessage "${pw}"' "$SCRIPTS"/pihole-install.sh  || ! grep -q "setAdminFlag$" "$SCRIPTS"/pihole-install.sh \

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 183 in c1a2f5c

    
           if ! grep -q 'displayFinalMessage "${pw}"' "$SCRIPTS"/pihole-install.sh  || ! grep -q "setAdminFlag$" "$SCRIPTS"/pihole-install.sh \

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 183 in c1a2f5c

    
           if ! grep -q 'displayFinalMessage "${pw}"' "$SCRIPTS"/pihole-install.sh  || ! grep -q "setAdminFlag$" "$SCRIPTS"/pihole-install.sh \

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 184 in c1a2f5c

    
           || ! grep -q "chooseInterface$" "$SCRIPTS"/pihole-install.sh || ! grep -q "getStaticIPv4Settings$" "$SCRIPTS"/pihole-install.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 184 in c1a2f5c

    
           || ! grep -q "chooseInterface$" "$SCRIPTS"/pihole-install.sh || ! grep -q "getStaticIPv4Settings$" "$SCRIPTS"/pihole-install.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 186 in c1a2f5c

msg_box "It seems like some functions in pihole-install.sh have changed.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 188 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 192 in c1a2f5c

    
           sed -i 's|displayFinalMessage "${pw}"|echo displayFinalMessage|' "$SCRIPTS"/pihole-install.sh # We don't want to display the final message

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 193 in c1a2f5c

    
           sed -i "s|setAdminFlag$|echo setAdminFlag|" "$SCRIPTS"/pihole-install.sh # We want to install the web-interface and lighttpd

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 194 in c1a2f5c

    
           sed -i "s|chooseInterface$|echo chooseInterface|" "$SCRIPTS"/pihole-install.sh # We don't want the user choose the interface

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 195 in c1a2f5c

    
           sed -i "s|getStaticIPv4Settings$|echo getStaticIPv4Settings|" "$SCRIPTS"/pihole-install.sh # We don't want to set a static ip4

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 198 in c1a2f5c

PIHOLE_INTERFACE="$IFACE"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 199 in c1a2f5c

export PIHOLE_INTERFACE

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 202 in c1a2f5c

apt-mark unhold php"$PHPVER"*

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 205 in c1a2f5c

bash "$SCRIPTS"/pihole-install.sh | tee "$SCRIPTS"/pihole-install.report

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 208 in c1a2f5c

unset INSTALLED

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 209 in c1a2f5c

    
           INSTALLED=$(grep "Checking for" "$SCRIPTS"/pihole-install.report | grep "will be installed" | awk '{print $8}')

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 209 in c1a2f5c

    
           INSTALLED=$(grep "Checking for" "$SCRIPTS"/pihole-install.report | grep "will be installed" | awk '{print $8}')

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 210 in c1a2f5c

check_command rm "$SCRIPTS"/pihole-install.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 211 in c1a2f5c

check_command rm "$SCRIPTS"/pihole-install.report

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 214 in c1a2f5c

if [ -z "${INSTALLED[*]}" ]

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 214 in c1a2f5c

if [ -z "${INSTALLED[*]}" ]

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 216 in c1a2f5c

msg_bos "Something is wrong. Didn't expect that no requirement get installed.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 221 in c1a2f5c

mapfile -t INSTALLED <<< "${INSTALLED[@]}"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 224 in c1a2f5c

mkdir -p "$SCRIPTS"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 227 in c1a2f5c

cat << PIHOLE_UPDATE > "$SCRIPTS/pihole-update.sh"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 255 in c1a2f5c

chown root:root "$SCRIPTS/pihole-update.sh"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 256 in c1a2f5c

chmod 700 "$SCRIPTS/pihole-update.sh"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 259 in c1a2f5c

if ! pihole &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 259 in c1a2f5c

if ! pihole &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 261 in c1a2f5c

msg_box "Something got wrong during pihole-install.sh

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 263 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 267 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "REV_SERVER" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 267 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "REV_SERVER" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 267 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "REV_SERVER" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 269 in c1a2f5c

cat << PIHOLE_CONF >> /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 271 in c1a2f5c

    
           REV_SERVER_CIDR=$(ip route | grep -v "default via" | grep "$IFACE" | awk '{print $1}' | grep "/")

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 278 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "DNS_FQDN_REQUIRED" /etc/pihole/setupVars.conf && ! grep -q "DNS_BOGUS_PRIV" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 278 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "DNS_FQDN_REQUIRED" /etc/pihole/setupVars.conf && ! grep -q "DNS_BOGUS_PRIV" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 278 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "DNS_FQDN_REQUIRED" /etc/pihole/setupVars.conf && ! grep -q "DNS_BOGUS_PRIV" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 278 in c1a2f5c

    
           if [ -f /etc/pihole/setupVars.conf ] && ! grep -q "DNS_FQDN_REQUIRED" /etc/pihole/setupVars.conf && ! grep -q "DNS_BOGUS_PRIV" /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 280 in c1a2f5c

cat << PIHOLE_CONF >> /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 287 in c1a2f5c

print_text_in_color "$ICyan" "Restarting pihole..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 288 in c1a2f5c

sleep 5

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 291 in c1a2f5c

if ! pihole restartdns

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 291 in c1a2f5c

if ! pihole restartdns

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 293 in c1a2f5c

msg_box "Something got wrong during the Pi-hole restart.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 295 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 299 in c1a2f5c

    
           check_command sudo sed -i '/^server.port/s/80/8093/' /etc/lighttpd/lighttpd.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 302 in c1a2f5c

print_text_in_color "$ICyan" "Restarting lighttpd..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 303 in c1a2f5c

sleep 5

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 306 in c1a2f5c

if ! systemctl restart lighttpd

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 306 in c1a2f5c

if ! systemctl restart lighttpd

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 308 in c1a2f5c

msg_box "Couldn't restart lighttpd.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 310 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 314 in c1a2f5c

print_text_in_color "$ICyan" "Configuring Apache..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 315 in c1a2f5c

install_if_not apache2

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 316 in c1a2f5c

a2enmod headers

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 317 in c1a2f5c

a2enmod rewrite

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 318 in c1a2f5c

a2enmod ssl

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 319 in c1a2f5c

a2enmod proxy

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 320 in c1a2f5c

a2enmod proxy_http

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 323 in c1a2f5c

if version 22.04 "$DISTRO" 24.04.10

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 323 in c1a2f5c

if version 22.04 "$DISTRO" 24.04.10

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 325 in c1a2f5c

TLS13="+TLSv1.3"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 328 in c1a2f5c

cat << PIHOLE_CONF > "$SITES_AVAILABLE/pihole.conf"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 369 in c1a2f5c

check_command a2ensite pihole.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 372 in c1a2f5c

if ! restart_webserver

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 372 in c1a2f5c

if ! restart_webserver

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 374 in c1a2f5c

msg_box "Apache2 could not restart...

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 376 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 380 in c1a2f5c

PASSWORD=$(gen_passwd 12 "a-zA-Z0-9")

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 380 in c1a2f5c

PASSWORD=$(gen_passwd 12 "a-zA-Z0-9")

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 383 in c1a2f5c

check_command pihole -a -p "$PASSWORD"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 386 in c1a2f5c

IPV6_ADDRESS=$(grep "IPV6_ADDRESS=" /etc/pihole/setupVars.conf)

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 386 in c1a2f5c

IPV6_ADDRESS=$(grep "IPV6_ADDRESS=" /etc/pihole/setupVars.conf)

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 387 in c1a2f5c

IPV6_ADDRESS="${IPV6_ADDRESS##*IPV6_ADDRESS=}"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 390 in c1a2f5c

crontab -u root -l | grep -v "pihole-update.sh" | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 391 in c1a2f5c

    
           crontab -u root -l | { cat; echo "30 19 * * 6 $SCRIPTS/pihole-update.sh >/dev/null" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 391 in c1a2f5c

    
           crontab -u root -l | { cat; echo "30 19 * * 6 $SCRIPTS/pihole-update.sh >/dev/null" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 391 in c1a2f5c

    
           crontab -u root -l | { cat; echo "30 19 * * 6 $SCRIPTS/pihole-update.sh >/dev/null" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 394 in c1a2f5c

ufw allow 53/tcp comment 'Pi-hole TCP' &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 395 in c1a2f5c

ufw allow 53/udp comment 'Pi-hole UDP' &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 396 in c1a2f5c

ufw allow 8094/tcp comment 'Pi-hole Web' &>/dev/null

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 399 in c1a2f5c

msg_box "Congratulations, your Pi-hole was set up correctly!

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 406 in c1a2f5c

    
           msg_box "You can now configure your devices to use the Pi-hole as their DNS server using:

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 411 in c1a2f5c

msg_box "How to use Pi-hole on the command line:

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 420 in c1a2f5c

msg_box "Concerning updates:

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 427 in c1a2f5c

    
           if ! yesno_box_yes "Do you want to enables your Pi-hole to be a recursive DNS server?

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 427 in c1a2f5c

    
           if ! yesno_box_yes "Do you want to enables your Pi-hole to be a recursive DNS server?

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 430 in c1a2f5c

exit

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 434 in c1a2f5c

install_if_not unbound

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 436 in c1a2f5c

cat << UNBOUND_CONF > /etc/unbound/unbound.conf.d/pi-hole.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 464 in c1a2f5c

print_text_in_color "$ICyan" "Restarting unbound..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 465 in c1a2f5c

sleep 10 & spinner_loading

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 465 in c1a2f5c

sleep 10 & spinner_loading

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 468 in c1a2f5c

check_command service unbound restart

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 471 in c1a2f5c

if ! dig sigfail.verteiltesysteme.net @127.0.0.1 -p 5335 | grep -q "SERVFAIL"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 471 in c1a2f5c

if ! dig sigfail.verteiltesysteme.net @127.0.0.1 -p 5335 | grep -q "SERVFAIL"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 473 in c1a2f5c

msg_box "Something got wrong while testing SERVFAIL.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 475 in c1a2f5c

elif ! dig sigok.verteiltesysteme.net @127.0.0.1 -p 5335 | grep -q "NOERROR"

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 477 in c1a2f5c

msg_box "Something got wrong while testing NOERROR.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 482 in c1a2f5c

    
           sed -i 's|^PIHOLE_DNS_1=.*|PIHOLE_DNS_1=127.0.0.1#5335|' /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 483 in c1a2f5c

sed -i '/^PIHOLE_DNS_2=.*/d' /etc/pihole/setupVars.conf

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 486 in c1a2f5c

print_text_in_color "$ICyan" "Restarting pihole..."

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 487 in c1a2f5c

sleep 5

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 490 in c1a2f5c

if ! pihole restartdns

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 490 in c1a2f5c

if ! pihole restartdns

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 492 in c1a2f5c

msg_box "Something got wrong during the Pi-hole unbound restart.

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 494 in c1a2f5c

exit 1

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 498 in c1a2f5c

crontab -u root -l | grep -v "systemctl restart unbound" | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 499 in c1a2f5c

    
           crontab -u root -l | { cat; echo "@hourly systemctl restart unbound" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 499 in c1a2f5c

    
           crontab -u root -l | { cat; echo "@hourly systemctl restart unbound" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 499 in c1a2f5c

    
           crontab -u root -l | { cat; echo "@hourly systemctl restart unbound" ; } | crontab -u root -

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 502 in c1a2f5c

msg_box "Congratulations!

📝 [shellcheck] _{reported by reviewdog 🐶}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). SC2317

vm/not-supported/pi-hole.sh

Line 505 in c1a2f5c

exit

Signed-off-by: Simon L. <[email protected]>

szaimen added the 3. to review label Feb 27, 2025

szaimen requested a review from enoch85 February 27, 2025 21:39

szaimen force-pushed the enh/noid/deprecate-pihole-script branch from 6de6603 to c1a2f5c Compare February 27, 2025 21:40

szaimen mentioned this pull request Feb 27, 2025

rewrite pi-hole script szaimen/Nextcloud-NAS-Guide#133

Open

github-actions bot reviewed Feb 27, 2025

View reviewed changes

deprecate pihole install script

f3890f3

Signed-off-by: Simon L. <[email protected]>

szaimen force-pushed the enh/noid/deprecate-pihole-script branch from c1a2f5c to f3890f3 Compare February 27, 2025 21:46

enoch85 merged commit f725b49 into main Feb 27, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deprecate pihole install script #2730

deprecate pihole install script #2730

szaimen commented Feb 27, 2025 •

edited

Loading

github-actions bot left a comment

deprecate pihole install script #2730

deprecate pihole install script #2730

Conversation

szaimen commented Feb 27, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

szaimen commented Feb 27, 2025 •

edited

Loading