Security: Overly Permissive Content Security Policy#1177
Open
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Open
Security: Overly Permissive Content Security Policy#1177tomaioo wants to merge 1 commit intonextcloud:mainfrom
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Conversation
The CSP in AddContentSecurityPolicyListener.php allows connections to all domains ('*') for connect-src, worker-src, and font-src. This enables the whiteboard to connect to arbitrary external servers, potentially exfiltrating data or receiving malicious content.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Overly Permissive Content Security Policy
Problem
Severity:
High| File:lib/Listener/AddContentSecurityPolicyListener.php:L29The CSP in AddContentSecurityPolicyListener.php allows connections to all domains ('*') for connect-src, worker-src, and font-src. This enables the whiteboard to connect to arbitrary external servers, potentially exfiltrating data or receiving malicious content.
Solution
Replace wildcard '' with specific allowed domains for the collab backend. If the backend URL is configurable, use that specific domain instead of ''.
Changes
lib/Listener/AddContentSecurityPolicyListener.php(modified)