Skip to content

local centric#393

Merged
juliusknorr merged 1 commit into
mainfrom
local-centric-approach
Apr 30, 2025
Merged

local centric#393
juliusknorr merged 1 commit into
mainfrom
local-centric-approach

Conversation

@hweihwang
Copy link
Copy Markdown
Contributor

@hweihwang hweihwang commented Mar 3, 2025

No description provided.

@hweihwang hweihwang force-pushed the local-centric-approach branch from 1a14345 to 94d3ec7 Compare March 3, 2025 12:15
@hweihwang hweihwang linked an issue Mar 3, 2025 that may be closed by this pull request
Proposal: Client-Centric Architecture Option #392
Closed
@hweihwang hweihwang changed the title init local centric Mar 3, 2025
@hweihwang hweihwang force-pushed the local-centric-approach branch 3 times, most recently from 57bea48 to 1cf06ad Compare March 5, 2025 07:49
@hweihwang hweihwang self-assigned this Mar 5, 2025
@hweihwang hweihwang force-pushed the local-centric-approach branch 7 times, most recently from c5049f6 to d7b6b70 Compare March 11, 2025 12:13
@hweihwang hweihwang marked this pull request as ready for review March 11, 2025 12:13
@hweihwang hweihwang requested a review from grnd-alt as a code owner March 11, 2025 12:13
@hweihwang hweihwang requested a review from juliusknorr March 11, 2025 12:14
@hweihwang
Copy link
Copy Markdown
Contributor Author

hweihwang commented Mar 11, 2025 •
edited
Loading

I know this is a lot but really worth trying and checking. It might improve the UX, DX, semi-offline mode editing support, get rid of data-loss and connectivity issues.

Please pull and test and let me know your thoughts and comments @juliusknorr @grnd-alt

Hopefully can apply some of the changes since i think it's good there

@hweihwang hweihwang force-pushed the local-centric-approach branch from d7b6b70 to 3ac5e4e Compare March 11, 2025 12:33
@hweihwang hweihwang force-pushed the local-centric-approach branch 2 times, most recently from 5942c30 to 72fd3a4 Compare March 25, 2025 09:52
juliusknorr
juliusknorr reviewed Mar 28, 2025
View reviewed changes
Comment thread websocket_server/AppManager.js
juliusknorr
juliusknorr reviewed Mar 28, 2025
View reviewed changes
Comment thread lib/Controller/WhiteboardController.php Outdated
@juliusknorr juliusknorr moved this to 🏗️ In progress in 📝 Productivity team Mar 31, 2025
@hweihwang hweihwang force-pushed the local-centric-approach branch 4 times, most recently from aad60cc to ff76156 Compare April 4, 2025 10:49
@hweihwang hweihwang requested a review from juliusknorr April 4, 2025 10:49
@hweihwang hweihwang force-pushed the local-centric-approach branch 16 times, most recently from e4c7565 to 748482d Compare April 19, 2025 10:08
@hweihwang
Copy link
Copy Markdown
Contributor Author

hweihwang commented Apr 19, 2025

Playwright tests fixed, turns out my stupid changes at vite build configs to output all to the ./js dir!!!

@hweihwang hweihwang requested a review from grnd-alt April 19, 2025 10:20
@hweihwang hweihwang moved this from 🏗️ In progress to 👀 In review in 📝 Productivity team Apr 21, 2025
@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented Apr 22, 2025 •
edited
Loading

I'm fine to merge, please just add a meaningful commit message ;) @hweihwang Can you put in a proper one there?

@grnd-alt Any further feedback / blockers from your side?

Current plan for testing would be to do a testing round on our daily instance for next weeks team call. After that we can publish a (pre)release or release depending on how confident we are with the changeset.

@hweihwang hweihwang force-pushed the local-centric-approach branch 3 times, most recently from b6deec7 to 6b05bc0 Compare April 29, 2025 13:16
@hweihwang
Copy link
Copy Markdown
Contributor Author

hweihwang commented Apr 30, 2025 •
edited
Loading

Resolved:

  • Saving not work when component unmount
  • Local data leakage between different fileId
  • Users joined room multiple times

@juliusknorr @grnd-alt

@hweihwang
re-architect from websocket server heavy lifting to client-side proce…
a6a2332 
…ssing, overall refactoring and optimizing

Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@juliusknorr
Copy link
Copy Markdown
Member

juliusknorr commented Apr 30, 2025

@grnd-alt Merging so we can get this pushed to daily, for the branchoff you can pick the previous merge commit then

@grnd-alt grnd-alt mentioned this pull request May 8, 2025
Closed
@hweihwang hweihwang mentioned this pull request Jun 5, 2025
Closed
@DonGiovanni83 DonGiovanni83 mentioned this pull request Nov 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@grnd-alt grnd-alt Awaiting requested review from grnd-alt grnd-alt is a code owner

Assignees

@hweihwang hweihwang

Labels

None yet

Projects

📝 Productivity team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Client-Centric Architecture Option

3 participants

@hweihwang @juliusknorr @grnd-alt