Fix AgentLogObserver printing [SUCCESS] on failed runs#6962
Merged
Conversation
Check session.isSuccess() in addition to task failedCount so that session-level errors (aborted, cancelled, failOnIgnore) correctly produce a [FAILED] summary line. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.isSuccess()inAgentLogObserver.printSummary()so that session-level errors (aborted, cancelled, failOnIgnore) correctly produce a[FAILED]summary linefailedCountwas checked, causing[SUCCESS]to be printed even when the session exited with code 1Fixes #6959
Test plan
[FAILED]is printed when session has error but zero task failuresnextflow module runwith missing params and verify[FAILED]in summary🤖 Generated with Claude Code