Mask fusion mount and s3 bucket names#200
Open
heuermh wants to merge 3 commits intonextflow-io:masterfrom
Open
Mask fusion mount and s3 bucket names#200heuermh wants to merge 3 commits intonextflow-io:masterfrom
heuermh wants to merge 3 commits intonextflow-io:masterfrom
Conversation
heuermh
commented
Feb 5, 2026
|
|
||
| @ConfigOption | ||
| @Description('A list of subpaths to mask from path values.') | ||
| final public List<CharSequence> maskFromPaths |
|
|
||
| private CharSequence maybeMaskBucketNames(CharSequence value) { | ||
| if(config.summary.maskBucketNames) { | ||
| value = value.replaceAll(S3_BUCKET_PATH_PREFIX, '/[** masked **]/') |
Author
There was a problem hiding this comment.
Worth making [** masked **] a separate parameter?
nvnieuwk
reviewed
Mar 19, 2026
Collaborator
nvnieuwk
left a comment
There was a problem hiding this comment.
I think it would make more sense to make this one global config option that contains a list of String prefixes to mask from paths. This would make this function more portable to other systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mask
/fusion,/s3/bucket/,s3://bucket/and arbitrary subpaths from path values in summary messages.For our use case, we want to distribute
multiqc_report.htmlfiles without leaking details of our infrastructure.nextflow.config: