Skip to content

Cast strict syntax parameters to types#208

Open
nvnieuwk wants to merge 2 commits intomasterfrom
convert-strict-syntax-params
Open

Cast strict syntax parameters to types#208
nvnieuwk wants to merge 2 commits intomasterfrom
convert-strict-syntax-params

Conversation

@nvnieuwk
Copy link
Collaborator

This fixes the issue reported in this issue: nf-core/tools#4100 (comment)

@@ -1,5 +1,8 @@
package nextflow.validation.parameters

import static nextflow.cli.CmdRun.parseParamValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't do this since it creates a dependency on the CLI logic. We might remove the CLI code from the core runtime in the near future

I would just copy the function here instead. It's legacy code so it won't change anyway

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up! I'll do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants