Minor improvements for shift-assignment by merschformann · Pull Request #102 · nextmv-io/community-apps

merschformann · 2025-03-12T23:01:29Z

Description

Adds some suggestions for shift-assignment.

Move overlap calculation to func for readability
Avoid applying MIP constraints that are not needed (or would even cause a bug if missing)
- Unrelated to the recent changes
Upgrades linter to much more recent version
Ignores cyclo complexity of shift-assignment modeling code as readability of MIP model formulation doesn't necessary benefit from more complex code organization

…ective if not necessary

merschformann added 3 commits March 12, 2025 23:52

Moving overlap calculation into func, not adding some constraints/obj…

96477e7

…ective if not necessary

Avoid adding constraints if not defined

3783682

Using more recent linter, ignoring model creation cyclo complexity

f7d73a9

merschformann marked this pull request as ready for review March 12, 2025 23:21

Update test expectation

c27028f

nmisek approved these changes Mar 13, 2025

View reviewed changes

nmisek merged commit 61a561c into nmisek/update-shift-assignment-app Mar 13, 2025

nmisek deleted the merschformann/shift-assignment-suggestion branch March 13, 2025 00:54