Conversation
Contributor
Author
|
@nmisek this should be good to go! I didn't use the polylines in the output just yet, but we could look at adding it if we want. |
Contributor
Author
|
merschformann
approved these changes
Jun 6, 2025
Member
merschformann
left a comment
merschformann
left a comment
There was a problem hiding this comment.
Nice work! I think you still need to add it to the workflow config. And maybe we can drop the plotly req.
Anyway, I won't block as I am reviewing on mobile in a quiet minute during the wedding. 😊
| @@ -0,0 +1,5 @@ | |||
| # Define the packages required by your project here. | |||
| nextmv==0.27.0 | |||
| plotly==6.0.0 | |||
Member
There was a problem hiding this comment.
If I am not mistaken, plotly can be dropped as a requirement. Or am I missing something?
phil-nextmv
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an app that connects to Verso (VROOM API) and creates a geojson visual for output.