Improves license handling in java-gurobi-knapsack app#121
Merged
merschformann merged 2 commits intodevelopfrom Jun 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines how the Gurobi license file is handled by removing hardcoded workspace settings, improving documentation, and adding a container mount for the license.
- Removed the explicit
GRB_LICENSE_FILEsetting in the VS Code workspace. - Clarified and reformatted local license setup instructions in the README.
- Mounted the host license file in the dev container and updated its environment variable.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| java-gurobi-knapsack/java-gurobi-knapsack.code-workspace | Removed hardcoded license env var from launch config |
| java-gurobi-knapsack/README.md | Revised local license setup steps and list formatting |
| java-gurobi-knapsack/.devcontainer/devcontainer.json | Added host license mount and updated container env var |
Comments suppressed due to low confidence (3)
java-gurobi-knapsack/java-gurobi-knapsack.code-workspace:9
- Since the workspace no longer sets
GRB_LICENSE_FILE, consider adding a note in the README or workspace comments to remind users that the license must be placed in their home directory for the default lookup.
{
java-gurobi-knapsack/README.md:7
- Both local and platform steps are numbered '1.'—update the second to '2. Platform' (or adjust numbering) so the setup list increments correctly.
1. **Local**:
java-gurobi-knapsack/README.md:9
- This line appears unindented and missing a list marker, so it may not render as a sub-bullet; consider adding a '-' or indenting to match the surrounding list formatting.
(like Gurobi expects it). If you are using the dev container, it will be
sebastian-quintero
approved these changes
Jun 19, 2025
…-license-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves how the Gurobi license is handled in java-gurobi-knapsack app.
Changes