Skip to content

Improves license handling in java-gurobi-knapsack app#121

Merged
merschformann merged 2 commits intodevelopfrom
merschformann/improve-java-gurobi-example-license-handling
Jun 19, 2025
Merged

Improves license handling in java-gurobi-knapsack app#121
merschformann merged 2 commits intodevelopfrom
merschformann/improve-java-gurobi-example-license-handling

Conversation

@merschformann
Copy link
Copy Markdown
Member

Description

Improves how the Gurobi license is handled in java-gurobi-knapsack app.

Changes

  • Improves license handling in java-gurobi-knapsack.

@merschformann merschformann requested a review from Copilot June 18, 2025 23:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines how the Gurobi license file is handled by removing hardcoded workspace settings, improving documentation, and adding a container mount for the license.

  • Removed the explicit GRB_LICENSE_FILE setting in the VS Code workspace.
  • Clarified and reformatted local license setup instructions in the README.
  • Mounted the host license file in the dev container and updated its environment variable.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
java-gurobi-knapsack/java-gurobi-knapsack.code-workspace Removed hardcoded license env var from launch config
java-gurobi-knapsack/README.md Revised local license setup steps and list formatting
java-gurobi-knapsack/.devcontainer/devcontainer.json Added host license mount and updated container env var
Comments suppressed due to low confidence (3)

java-gurobi-knapsack/java-gurobi-knapsack.code-workspace:9

  • Since the workspace no longer sets GRB_LICENSE_FILE, consider adding a note in the README or workspace comments to remind users that the license must be placed in their home directory for the default lookup.
      {

java-gurobi-knapsack/README.md:7

  • Both local and platform steps are numbered '1.'—update the second to '2. Platform' (or adjust numbering) so the setup list increments correctly.
    1. **Local**:

java-gurobi-knapsack/README.md:9

  • This line appears unindented and missing a list marker, so it may not render as a sub-bullet; consider adding a '-' or indenting to match the surrounding list formatting.
        (like Gurobi expects it). If you are using the dev container, it will be

Comment thread java-gurobi-knapsack/.devcontainer/devcontainer.json
Comment thread java-gurobi-knapsack/.devcontainer/devcontainer.json
@merschformann merschformann merged commit b72de57 into develop Jun 19, 2025
40 checks passed
@merschformann merschformann deleted the merschformann/improve-java-gurobi-example-license-handling branch June 19, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants