Remove some interfaces around objectives #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes interface-based abstractions for model objectives, converting them to concrete struct types. The change simplifies the codebase by eliminating unnecessary interfaces and their corresponding implementation types.
- Removed interfaces like
VehiclesDurationObjective,VehiclesObjective,UnPlannedObjective, etc. and converted them to concrete structs - Eliminated implementation structs (e.g.,
vehiclesDurationObjectiveImpl) by promoting their fields to the main struct - Updated function return types from interfaces to concrete struct pointers
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| model_objective_vehicles_duration.go | Converted interface to struct, removed implementation type |
| model_objective_vehicles.go | Converted interface to struct, removed implementation type |
| model_objective_unplanned.go | Converted interface to struct, removed implementation type |
| model_objective_travelduration.go | Converted interface to struct, removed implementation type |
| model_objective_term.go | Converted interface to struct, removed implementation type |
| model_objective_stop_balancing.go | Renamed and converted implementation struct to main struct |
| model_objective_min_stops.go | Converted implementation struct to main struct |
| model_objective_expression_test.go | Updated test to use concrete type methods |
| model_objective_expression.go | Converted interface to struct, removed implementation type |
| model_objective_earliness.go | Converted interface to struct, removed implementation type |
| model_objective_distance.go | Converted interface to struct, removed implementation type |
| model_objective.go | Converted sum interface to struct, removed implementation type |
| model.go | Updated objective field type to concrete struct pointer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
merschformann
approved these changes
Oct 13, 2025
Member
merschformann
left a comment
merschformann
left a comment
There was a problem hiding this comment.
Nice, thank you. One interface at a time. ❤️
Comment on lines
+69
to
+71
| // Earliness returns the earliness of a stop. The earliness is the | ||
| // difference between target time and the actual arrival, start or stop of a | ||
| // stop. Depending on the TemporalReference. |
Member
There was a problem hiding this comment.
I'd love us to improve our comments / code docs here, but that is besides the point of this PR. ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.