Add transition animation when panel options are shown/hidden #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently has two problems: 1. It does not allow dropdowns from within the options to render lower than the boundaries. 2. It transitions the height from viewport height to 0, however all the actual panel option divs are shorter than that. This means there is a delay before the transition makes a visible change, and the speed is much faster than if it went from panel option div's height to 0. (2) is more of a nuisance and can be addressed by dynamically setting the max-height based on the containing div's scrollHeight, however (1) is the prevailing and blocking problem.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-panel-mz1k9o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Suggested by @ivan-aksamentov on Slack.
Related issue(s)
Checklist