Tree buttons for each tree #2026
Open
+88
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the main `TreeComponent` which is a welcome change in and of itself, and also sets the stage for upcoming changes such as <#1993> which will add complexity to the buttons functionality, as well as the next commit...
nextstrain-bot
temporarily deployed
to
auspice-james-tree-butt-bo8wc9
For single trees (i.e. 99% of Auspice usage) there should be no changes. For tangle-trees I often want more fine-grained control than the current situation and making the buttons per-tree gives me this. There are occasions where we'll now have to click two buttons, but that's an acceptable trade off for me. (Perhaps we can implement a shift-click to apply to both trees if this really frustrates someone!) Aesthetically we need a little more space above trees to duplicate the buttons and also have the tree names shown. The tree names themselves were implemented as an afterthought really and could be improved one day.
jameshadfield
force-pushed
the
james/tree-buttons
branch
from
216fec3 to
37f0352
Compare
jameshadfield
temporarily deployed
to
auspice-james-tree-butt-bo8wc9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For single trees (i.e. 99% of Auspice usage) there should be no changes.
For tangle-trees I often want more fine-grained control than the current situation and making the buttons per-tree gives me this. There are occasions where we'll now have to click two buttons, but that's an acceptable trade off for me. (Perhaps we can implement a shift-click to apply to both trees if this really frustrates someone!)
Example: