Import "nextstrain-ncov-private" bucket and associated configuration#70
Merged
Merged
Conversation
Similar to "Import "nextstrain-tmp" bucket and associated configuration" (cdc7c48) for another bucket. One difference is that this imports everything, while the associated configuration for nextstrain-tmp was deliberately not imported (Terraform created new resources that replaced the existing ones). I think it makes more sense to import everything so that nothing happens on the AWS side, and is implied by the rule of thumb in the README. Plan shows "4 to import, 0 to add, 0 to change, 0 to destroy".
joverlee521
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Similar to #45 for another bucket.
One difference is that this imports everything, while the associated configuration for nextstrain-tmp was deliberately not imported (Terraform created new resources that replaced the existing ones). I think it makes more sense to import everything so that nothing happens on the AWS side, and is implied by the rule of thumb in the README.
Plan shows "4 to import, 0 to add, 0 to change, 0 to destroy".
Related issue(s)
Prep for https://github.com/nextstrain/private/issues/180
Checklist