Add benchmark and --stats - #451
Merged
Merged
Conversation
Adding as part of #240 to help collect more data for tackling #446. One unexpected behavior that I ran into when testing the `--stats` option is that Snakemake doesn't generate the stats file if the workflow exits with an error at any step. Note that the Snakemake `--stats` option is not available starting with Snakemake v8, so this will need to be removed when we eventually upgrade Snakemake in our runtimes.
The use of `shellquote` was removed in 2dab1f9.
Per Nextstrain's Snakemake style guide, using the `message` directive overrides the default Snakemake outputs which includes other critical details. <https://docs.nextstrain.org/en/latest/reference/snakemake-style-guide.html#avoid-the-message-rule-attribute>
huddlej
reviewed
Jun 18, 2024
huddlej
left a comment
huddlej
left a comment
Contributor
There was a problem hiding this comment.
I love benchmarks! +1 for their inclusion in our Snakemake style guide, @joverlee521.
Contributor
Author
I merged nextstrain/docs.nextstrain.org#210 yesterday, but it's not available in our latest docs yet because RTD build is currently failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add benchmark for all Snakemake rules and use
--statsto get more data for #446.I plan on merging tomorrow morning before the automated workflow runs at ~11am PT.
Related issue(s)
Resolves #240
Gathering stats for #446
Checklist