Skip to content

Convert sars forecasts to app router [#1125]#1126

Merged
genehack merged 2 commits intomasterfrom
convert-sars-forecasts-to-app-router-1125
Mar 10, 2025
Merged

Convert sars forecasts to app router [#1125]#1126
genehack merged 2 commits intomasterfrom
convert-sars-forecasts-to-app-router-1125

Conversation

@genehack
Copy link
Contributor

@genehack genehack commented Feb 28, 2025

Description of proposed changes

Converts /sars-cov-2/forecasts to App Router style.

Note: built on top of #1124; pushing now for review and tests but should only merge on top of that PR.

Related issue(s)

Closes #1125

Checklist

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-convert-sa-muwyht February 28, 2025 20:07 Inactive
@genehack genehack force-pushed the convert-sars-forecasts-to-app-router-1125 branch from 44668a1 to e17cfc1 Compare March 6, 2025 20:59
@genehack genehack temporarily deployed to nextstrain-s-convert-sa-muwyht March 6, 2025 21:00 Inactive
@genehack genehack force-pushed the convert-sars-forecasts-to-app-router-1125 branch from e17cfc1 to af42511 Compare March 6, 2025 21:17
@genehack genehack temporarily deployed to nextstrain-s-convert-sa-muwyht March 6, 2025 21:18 Inactive
@joverlee521
Copy link
Contributor

Note: built on top of #1124; pushing now for review and tests but should only merge on top of that PR.

Just FYI, changing the base branch for the PR to convert-pathogens-to-app-router-1066 will facilitate highlighting the changes only in this PR and ensures this will only merge on top of that PR.

@genehack genehack changed the base branch from master to convert-pathogens-to-app-router-1066 March 7, 2025 00:55
@genehack
Copy link
Contributor Author

genehack commented Mar 7, 2025

Note: built on top of #1124; pushing now for review and tests but should only merge on top of that PR.

Just FYI, changing the base branch for the PR to convert-pathogens-to-app-router-1066 will facilitate highlighting the changes only in this PR and ensures this will only merge on top of that PR.

thanks, done — i always forget GH supports that.

@genehack genehack force-pushed the convert-pathogens-to-app-router-1066 branch from feb55a3 to 3a75a9a Compare March 10, 2025 21:28
Base automatically changed from convert-pathogens-to-app-router-1066 to master March 10, 2025 21:37
Note: this will leave the site in a broken state; doing this to ensure
better Git tracking of file renames.
* Move styles into CSS module
* Refactor code for consistency with other App Router pages
* Switch abstract section from <FocusParagraph> to
  <FocusParagraphNarrow> for consistency with other pages
* Add Metadata export

NOTE: This changes the width of the "abstract" section of the page so
that it matches other pages on the site; previously, the "abstract"
section of the `/sars-cov-2/forecasts` was wider than the 640px
default used on other pages.

Having everything use a consistent layout is an obvious maintenance
win; I picked the 640px variation because that's more common across
all the existing site pages.
@genehack genehack force-pushed the convert-sars-forecasts-to-app-router-1125 branch from af42511 to 6b91575 Compare March 10, 2025 21:40
@genehack genehack temporarily deployed to nextstrain-s-convert-sa-muwyht March 10, 2025 21:40 Inactive
@genehack genehack merged commit 279f3b4 into master Mar 10, 2025
8 checks passed
@genehack genehack deleted the convert-sars-forecasts-to-app-router-1125 branch March 10, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port /sars-cov-2/forecasts to App Router

3 participants