Conversation
I assume migration to NW-PaGe is to either a Nextstrain group or community dataset. If that's the case, it doesn't make sense to add to |
j23414
changed the title
| "WNV": { | ||
| "resolution": { | ||
| "all-lineages": "", | ||
| "wa": "", |
There was a problem hiding this comment.
This renders the URL https://nextstrain.org/WNV/wa invalid. Is the new NW-PaGe dataset ready? It should be possible to encode a redirect in src/redirects.js from /WNV/wa to /groups/… if desired. Note that it would be a redirect for the direct URL, not an entry in the dataset selector which is based on manifest.
There was a problem hiding this comment.
Wait, actually it will still work, but we don't want that as it'll become out of date if it's not automatically updated by the workflow: https://nextstrain-s-drop-wnv-w-o8gyt6.herokuapp.com/WNV/wa
To properly remove /WNV/wa, it needs to be removed from S3.
There was a problem hiding this comment.
Since we just migrated last week and I know some people are busy this week, I'd estimate that the NW-PaGe dataset might not be ready until April 4th or later.
Good to know about the redirects! I can ping NW-PaGe next week for an update/if they would like the redirect option. In the meantime, I don't think we need to maintain a valid URL https://nextstrain.org/WNV/wa as it seems like NW-PaGe would like to manage the WA view themselves
There was a problem hiding this comment.
To properly remove /WNV/wa, it needs to be removed from S3.
I'm happy to nextstrain remote rm from S3
I'll probably do a nextstrain remote ls check for WNV Auspice datasets. I probably need to remove some old non-updating "global". I'll leave NA since that's tied to a narrative
There was a problem hiding this comment.
The redirect would be more for ourselves so we don't break our own URL. I see that /WNV/wa was only recently added in ff1e6d2 so maybe it's fine to break. Another option is to redirect to an existing core dataset, i.e. /WNV/wa → /WNV/all-lineages. I don't have any opinions here, just want to list out some options.
There was a problem hiding this comment.
That's fair! Thanks for listing the other options, and this thread does help clarify my thinking on this and similar PRs 😄 No worries!
I lean toward not supporting /WNV/wa -> /WNV/all-lineages redirects as /WNV/wa was only recently added, and was fated to be dropped anyway. And as a user, I'd be confused on why "WNV/wa (state)" was sending me to WNV/all-lineages (global)
There was a problem hiding this comment.
I'm happy to
nextstrain remote rmfrom S3
👍
I probably need to remove some old non-updating "global".
You could also redirect /WNV/global to /WNV/all-lineages (in addition to removing the global JSON from S3).
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
I assume this needs coordination with the workflow side of things, i.e. nextstrain/WNV#81, so I trust your judgement on when to merge this.
3 participants
Description of proposed changes
Part of migration of WA WNV trees to NW-PaGe
Related issue(s)
Checklist
Optional step: Add NW-PaGe to manifest[Edit: 2025-03-24] Noop, migrate to Nextstrain group so different system