Change pathogens to splat [#1133]#1136
Closed
genehack wants to merge 21 commits intoremediate-already-ported-bits-1133from
Closed
Change pathogens to splat [#1133]#1136genehack wants to merge 21 commits intoremediate-already-ported-bits-1133from
genehack wants to merge 21 commits intoremediate-already-ported-bits-1133from
Conversation
….. [#1133] ...for a invalid request path.
genehack
force-pushed
the
remediate-already-ported-bits-1133
branch
from
495b694 to
1379814
Compare
Contributor
Author
victorlin
reviewed
Mar 21, 2025
Comment on lines
+18
to
+20
| if (params && params["pathogens"]) { | ||
| notFound(); | ||
| } |
Member
There was a problem hiding this comment.
See suggestion to use pathogens/[[...slug]]: #1131 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Converts
/pathogensover to using a "splat path" and adds an error banner display when somebody asks for a non-existent/pathogens/URL.Related issue(s)
Closes #1133
Checklist