pathogen/files: Add data use language#1311
Merged
Conversation
The wording of the note in the ListResources assumes there is a link to
Restricted Data Terms of Use somewhere above on the same page. This is
true with the change to PathogenWorkflowFiles, but note that it is
loosely coupled.
The wording ("may contain") is not definite because it is naively
conditional on the string "restricted" being present in the filename,
which doesn't guarantee actual presence of restricted data.
I chose Remix Design's warning icon to visually differentiate from
Material Design's warning icon.
Member
Author
|
This is what it looks like with both warnings (might happen in the future) 
|
joverlee521
approved these changes
Feb 6, 2026
Contributor
joverlee521
left a comment
joverlee521
left a comment
There was a problem hiding this comment.
Thanks for getting this up so quick! This PR LGTM, I only left suggestions for additional changes that we should do on top of this.
Contributor
There was a problem hiding this comment.
Could be a separate change, but I think we still want to add the language for acknowledging data contributors and to avoid scooping
Member
Author
There was a problem hiding this comment.
Added to this PR as ad87c1f.
This block of intro text is getting quite lengthy. After merging this we should explore ways to condense it while keeping all the important points.
Copied from zika's default dataset description.¹ ¹ https://github.com/nextstrain/zika/blob/d72cdcc/phylogenetic/defaults/description.md#L1-L5
victorlin
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The wording of the note in the ListResources assumes there is a link to Restricted Data Terms of Use somewhere above on the same page. This is true with the change to PathogenWorkflowFiles, but note that it is loosely coupled.
The wording ("may contain") is not definite because it is naively conditional on the string "restricted" being present in the filename, which doesn't guarantee actual presence of restricted data.
I chose Remix Design's warning icon to visually differentiate from Material Design's warning icon.
Related issue(s)
Closes #1310
Checklist
Check if changes affect the resource index JSON revision