Skip to content

Limit Next.js delegation to GET/HEAD requests #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
victorlin merged 1 commit into from
Feb 24, 2026
Merged

Limit Next.js delegation to GET/HEAD requests #1318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/routing/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ export async function setup(app) {
.end();
}

if (err instanceof NotFound) {
/* Delegate to Next.js only for GET and HEAD requests. This aligns with
* handling in src/routing/staticSite.js.
*/
if (err instanceof NotFound && ["GET", "HEAD"].includes(req.method)) {
/* A note about routing: if the current URL path (i.e. req.path) matches a
* a page known to the NextJS routes ("pages") then that page will be
* shown (with response code 200). Moving to server-side rendering of
Expand Down