Move user error detection into custom error handler#1321
Merged
Conversation
Existing behavior from Express's custom error handler¹ is retained. To be modified later. ¹ https://github.com/expressjs/express/blob/b4ab7d65d7724d9309b6faaaf82ad492da2a6d35/lib/application.js#L153-L157
A better alternative to the previous implementation that avoids logging
the error message again after the custom [verbose] message.
In the example below, the unnecessary 2nd log line is removed:
[verbose] Sending NotFoundError: Not Found error as HTML with custom error handler
NotFoundError: Not Found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains 1 prep commit + 1 main commit. Message from main commit:
A better alternative to the previous implementation that avoids logging the error message again after the custom [verbose] message.
In the example below, the unnecessary 2nd log line is removed:
(follow-up to #1320 and old TODO)
Checklist