Conversation
jameshadfield
approved these changes
Mar 3, 2026
Update the first comment to better explain the purpose of this code block, which only serves very specific routes such as '/charon/invalid'. The nested comment was also not entirely accurate, as Next.js can respond with 404 for some routes. I lifted it out and rewrote as a proper TODO based on the linked issues.
victorlin
force-pushed
the
victorlin/update-error-handling
branch
from
24cda24 to
6520f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the first comment to better explain the purpose of this code block, which only serves very specific routes such as '/charon/invalid'.
The nested comment was also not entirely accurate, as Next.js can respond with 404 for some routes. I lifted it out and rewrote as a proper TODO based on the linked issues.
Checklist
Check if changes affect the resource index JSON revision