fix(desktop): localize update fetch-failure message on Windows

[teddyli18000]

What

Normalize update fetch/network failure errors in the desktop renderer so Chinese users no longer see the raw English string fetch failed in update failure notifications.

Why

Closes #994.

On Windows with zh-CN UI, update failures could surface as mixed-language notifications (更新失败 with raw fetch failed detail), which is confusing and breaks localization consistency.

How

• Exported normalizeUpdateErrorMessage from the update hook for direct regression testing.
• Added a dedicated normalization branch for fetch-related failures:
  • fetch failed
  • failed to fetch
  • NetworkError ... fetch
• Mapped these errors to user-friendly localized messages:
  • EN: Network connection failed while checking for updates. Check your connection and try again.
  • ZH: 网络连接失败，请检查网络后重试。
• Added regression tests for both normal and local-test-feed update experiences.

Affected areas

• Desktop app (Electron shell)
• Controller (backend / API)
• Web dashboard (React UI)
• OpenClaw runtime
• Skills
• Shared schemas / packages
• Build / CI / Tooling

Checklist

• pnpm typecheck passes
• pnpm lint passes
• pnpm test passes
• pnpm generate-types run (if API routes/schemas changed)
• No credentials or tokens in code or logs
• No any types introduced (use unknown with narrowing)

Screenshots / recordings

• Reproduction:

• 

• Fixed:

Notes for reviewers

• Core code change: apps/desktop/src/hooks/use-auto-update.ts
• Regression tests: tests/desktop/update-error-message-normalization.test.ts
• Focus manual verification on update error banner text under zh-CN when update check fails due to network/feed failures.

[Copilot]

Pull request overview

This PR addresses a desktop i18n UX issue on Windows by normalizing fetch/network-related auto-update errors so localized UIs (notably zh-CN) don’t surface the raw English "fetch failed" string in update failure notifications.

Changes:

• Exported normalizeUpdateErrorMessage from the desktop auto-update hook to enable direct regression testing.
• Added normalization for fetch-related failure messages (fetch failed, failed to fetch, NetworkError ... fetch) mapping them to localized, user-friendly strings.
• Added Vitest regression tests covering both normal updates and local-test-feed update experiences.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
apps/desktop/src/hooks/use-auto-update.ts	Exposes and extends update error normalization to localize fetch/network failures.
tests/desktop/update-error-message-normalization.test.ts	Adds regression tests ensuring fetch-failure messages are normalized in both update experiences.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

These assertions only check that the output no longer contains the substring "fetch failed", which would still pass if the function returns a different raw English fetch-related message (e.g., "NetworkError when attempting to fetch…") or an empty/placeholder string. Consider asserting the exact expected normalized message (or a stable key phrase), and explicitly controlling the locale (e.g., temporarily set/define navigator.language to en-US and zh-CN) so the test validates the localized output deterministically.

Suggested change

	describe("update error message normalization", () => {
	it("normalizes fetch failures in normal update mode", () => {
	const result = normalizeUpdateErrorMessage("fetch failed", "normal");
	expect(result).not.toMatch(/fetch failed/i);
	});
	it("normalizes fetch failures in local test feed mode", () => {
	const result = normalizeUpdateErrorMessage(
	"TypeError: fetch failed",
	"local-test-feed",
	);
	expect(result).not.toMatch(/fetch failed/i);
	});
	const withNavigatorLanguage = <T>(language: string, run: () => T): T => {
	const originalDescriptor = Object.getOwnPropertyDescriptor(
	window.navigator,
	"language",
	);
	Object.defineProperty(window.navigator, "language", {
	configurable: true,
	value: language,
	});
	try {
	return run();
	} finally {
	if (originalDescriptor) {
	Object.defineProperty(window.navigator, "language", originalDescriptor);
	} else {
	delete (window.navigator as Navigator & { language?: string }).language;
	}
	}
	};
	describe("update error message normalization", () => {
	it("normalizes fetch failures in normal update mode for en-US", () => {
	const result = withNavigatorLanguage("en-US", () =>
	normalizeUpdateErrorMessage("fetch failed", "normal"),
	);
	expect(result).toContain("network");
	expect(result).not.toMatch(/fetch failed/i);
	});
	it("normalizes fetch failures in normal update mode for zh-CN", () => {
	const result = withNavigatorLanguage("zh-CN", () =>
	normalizeUpdateErrorMessage("fetch failed", "normal"),
	);
	expect(result).toContain("网络");
	expect(result).not.toMatch(/fetch failed/i);
	});
	it("normalizes fetch failures in local test feed mode for en-US", () => {
	const result = withNavigatorLanguage("en-US", () =>
	normalizeUpdateErrorMessage("TypeError: fetch failed", "local-test-feed"),
	);
	expect(result).toContain("local");
	expect(result).toContain("server");
	expect(result).not.toMatch(/fetch failed/i);
	});
	it("normalizes fetch failures in local test feed mode for zh-CN", () => {
	const result = withNavigatorLanguage("zh-CN", () =>
	normalizeUpdateErrorMessage("TypeError: fetch failed", "local-test-feed"),
	);
	expect(result).toContain("本地");
	expect(result).toContain("服务器");
	expect(result).not.toMatch(/fetch failed/i);
	});

[Copilot]

This test also only asserts that "fetch failed" is absent; it doesn't verify the actual user-facing string for the local-test-feed experience or that the output is localized under a zh locale. Strengthen it by forcing the locale and asserting the expected normalized message for both normal and local-test-feed inputs.

[sentry]

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
apps/desktop/src/hooks/use-auto-update.ts	88.88%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Celina-create]

@teddyli18000 👋你好呀～ 我们收到您今天提交了 2 次 Pr，我们非常感激你的贡献 🎉
我会在 24 小时内完成 Review，如果有需要修改或优化的地方，会在这里留言说明。 如果过程中有任何问题，随时可以沟通。另外，我们有一个 Nexu 开发者飞书交流群，加入可以更快获得反馈，也能和其他贡献者一起交流，也方便我们给您提供更多的支持和帮助。
nexu 开发者飞书交流群 👇
https://applink.feishu.cn/client/chat/chatter/add_by_link?link_token=054u93b4-f45e-4849-92d4-96a4d4a90d03

[teddyli18000]

Apologies for the noise in this PR.

The diff has ballooned to 4,000+ lines due to my AI assistant accidentally rebasing my branch on top of 6 unrelated prior commits during a revision pass. My actual changes remain the same as originally described:

• Core change: apps/desktop/src/hooks/use-auto-update.ts
• Test addition: tests/desktop/update-error-message-normalization.test.ts (~40 lines)

As this is my first contribution to this project, I appreciate your patience. I'll do my best to ensure cleaner PRs going forward. Please let me know if there's anything else you'd like me to address in the meantime.

Apologize again. I will do my best to contribute to nexu in the future.

[Copilot]

Pull request overview

Copilot reviewed 72 out of 73 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

apps/desktop/src/hooks/use-auto-update.ts:38

• The PR description/title focus on desktop update error localization, but this diff also includes substantial unrelated functional changes (SkillHub cancel/retry UX + new controller routes, OpenClaw restart/nudge behavior, schema changes, bundled-skill metadata rewrites, etc.). Please either narrow the PR to the update-message fix or update the PR description/scope so reviewers can assess the additional risk appropriately.

export function normalizeUpdateErrorMessage(
  message: string,
  experience: DesktopUpdateExperience,
): string {
  const trimmedMessage = message.trim();

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

stripRequiresBins() applies global regex replacements across the entire SKILL.md file, not just the YAML frontmatter. That can inadvertently delete legitimate markdown content or code blocks containing requires: / "requires": {...} outside the frontmatter. Consider restricting the edit to the extracted frontmatter region only (parse/replace inside the --- ... --- block, then reassemble).

Suggested change

	// JSON-in-YAML: "requires": { "bins": [...] }, or "requires": { "anyBins": [...] },
	// Remove the entire "requires": { ... }, block (with optional trailing comma)
	let patched = content.replace(/\s*"requires"\s*:\s*\{[^}]*\}\s*,?/g, "");
	// Standard YAML: requires:\n bins:\n - x\n - y
	// Remove the requires block and all its indented children
	patched = patched.replace(/^[ \t]*requires:\s*\n(?:[ \t]+.*\n)*/gm, "");
	if (patched !== content) {
	const frontmatterMatch = content.match(/^---\n([\s\S]*?)\n---/);
	if (!frontmatterMatch || frontmatterMatch.index == null) return;
	const frontmatter = frontmatterMatch[1] ?? "";
	// JSON-in-YAML: "requires": { "bins": [...] }, or "requires": { "anyBins": [...] },
	// Remove the entire "requires": { ... }, block (with optional trailing comma)
	let patchedFrontmatter = frontmatter.replace(
	/\s*"requires"\s*:\s*\{[^}]*\}\s*,?/g,
	"",
	);
	// Standard YAML: requires:\n bins:\n - x\n - y
	// Remove the requires block and all its indented children
	patchedFrontmatter = patchedFrontmatter.replace(
	/^[ \t]*requires:\s*\n(?:[ \t]+.*\n)*/gm,
	"",
	);
	if (patchedFrontmatter !== frontmatter) {
	const frontmatterStart = frontmatterMatch.index;
	const frontmatterEnd = frontmatterStart + frontmatterMatch[0].length;
	const patched =
	`${content.slice(0, frontmatterStart)}---\n${patchedFrontmatter}\n---` +
	content.slice(frontmatterEnd);

[Copilot]

useCancelInstall() throws a generic "Cancel request failed" when the SDK returns an error, which means the UI toast in SkillsPage will never show any actionable detail from the backend (HTTP status / message). Prefer propagating the SDK error message (or include it in the thrown Error) so users get a meaningful failure reason.

[Copilot]

In the runtime-model plugin, providerOverride is computed even when selectedModelRef has no "/" (so slashIndex is -1). Although it's currently not spread into the return object when slashIndex <= 0, computing it with slice(0, -1) is confusing and easy to misuse later. Consider only computing providerOverride inside the slashIndex > 0 branch.

[Copilot]

Changing OpenClawWatchTrigger to require an OpenClawProcessManager in the constructor is a breaking API change, but there are still call sites constructing it with a single argument (e.g. controller tests like apps/controller/tests/openclaw-sync.test.ts and apps/controller/tests/route-compat.test.ts). Those will fail to typecheck/run. Please update all instantiations (tests + any helpers) to pass a process manager (or provide a backwards-compatible default).

Suggested change

	private readonly openclawProcess: OpenClawProcessManager,
	private readonly openclawProcess?: OpenClawProcessManager,