feat: improve BYOK provider configuration and model management#1111
feat: improve BYOK provider configuration and model management#1111
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 196864584e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying nexu-docs with
|
| Latest commit: |
cbd78c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://096f0f40.nexu-docs.pages.dev |
| Branch Preview URL: | https://fix-provider-issues.nexu-docs.pages.dev |
Prevent unconfigured providers from showing model management actions and avoid emitting empty API keys in compiled provider configs.
mrcfps
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e201adc7cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa95d4cc23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: "gpt-5.4", | ||
| name: "GPT 5.4", |
There was a problem hiding this comment.
The OpenAI bundled list repeats gpt-5.4, and this now propagates into runtime behavior because empty provider model sets are backfilled from getBundledProviderModelIds(...) (used by resolveInventoryModelIds in model-provider-service and buildProviderConfig in nexu-config-store). In that scenario users get duplicate OpenAI model entries and duplicated saved model rows, which is a regression in model-management correctness.
Useful? React with 👍 / 👎.
| id: "MiniMax-M2.7", | ||
| name: "MiniMax M2.7", |
There was a problem hiding this comment.
The MiniMax bundled defaults include MiniMax-M2.7 twice, so any flow that falls back to bundled IDs when a provider has no explicit model list will surface duplicate MiniMax models. Since those fallbacks are now used in provider inventory and config seeding, this introduces duplicate UI/API model options and unnecessary duplicate persisted entries.
Useful? React with 👍 / 👎.
1 participant
What
Improve BYOK provider setup and model management across the controller, web UI, shared schemas, and generated SDK.
Why
Provider configuration and model selection had several rough edges in daily use. Some providers needed compatibility fixes, model discovery and availability checks were incomplete, and the UI still exposed model-management actions even when a provider was not configured.
How
Affected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
This PR now includes both provider compatibility fixes and the broader BYOK model-management work already accumulated on
fix/provider-issues, so the scope is wider than the original PR title/body suggested.