Skip to content

revert: PR #5301 - #5342

Merged
alchemistklk merged 1 commit into
feat/amr-login-failure-classifierfrom
revert-pr-5301
Jul 15, 2026
Merged

revert: PR #5301#5342
alchemistklk merged 1 commit into
feat/amr-login-failure-classifierfrom
revert-pr-5301

Conversation

@AmyShang-alt

Copy link
Copy Markdown
Contributor

Reverts #5301, which was accidentally merged into feat/amr-login-failure-classifier instead of the intended target.

Revert commit: fc2d930
Original merge commit: e22f9d3

No main-branch changes are involved.

@lefarcen
lefarcen requested a review from PerishCode July 9, 2026 07:59
@lefarcen lefarcen added size/XL PR changes 700-1500 lines risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps type/chore CI / build / config / tooling labels Jul 9, 2026
@lefarcen

lefarcen commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Quick PR-body ask: could you fill in Why / What users will see / Surface area / Validation before pool review picks this up?

Since this reverts a large AMR sign-in surface change, a short note on which user-visible pieces are intentionally rolled back on feat/amr-login-failure-classifier and what you re-validated after the revert would make the review pass a lot faster.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Visual regression review

Head: fc2d930 · Base: e22f9d3

Baseline unavailable; PR screenshots are new visual cases and need baseline review.

0 changed · 0 unchanged · 53 new without baseline · 0 failed

New cases without baselines

PR PR PR
visual-avatar-local-agent-list
pr
visual-avatar-local-agent-list-panel
pr
visual-avatar-menu
pr
visual-avatar-menu-panel
pr
visual-avatar-open-design-account
pr
visual-critical-settings
pr
visual-critical-workspace
pr
visual-critical-workspace-preview
pr
visual-design-system-detail
pr
visual-design-systems
pr
visual-home
pr
visual-home-catalog
pr
visual-home-context-picker
pr
visual-home-context-picker-popover
pr
visual-home-plugin-filter
pr
visual-home-plugin-use-staged
pr
visual-home-plugin-use-with-query
pr
visual-home-staged-attachment
pr
visual-integrations
pr
visual-integrations-mcp
pr

33 additional new case(s) omitted from this comment.

Visual diff is advisory only and does not block merging.

@PerishCode PerishCode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmyShang-alt I reviewed the changed ranges for the revert of #5301 across the daemon CLI, web AMR sign-in UI/runtime/i18n surfaces, tests, and the AMR login contract export. The patch cleanly removes the UI/CLI failure-reason presentation layer and its tests while leaving the underlying classifier contract shape intact on this branch; I did not find a correctness or boundary issue in the revert. Thanks for keeping the accidental merge rollback focused and easy to audit.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@alchemistklk
alchemistklk merged commit 4e9ca6c into feat/amr-login-failure-classifier Jul 15, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps size/XL PR changes 700-1500 lines type/chore CI / build / config / tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants