feat: Adding kimchi CLI option by bentleyvk · Pull Request #5376 · nexu-io/open-design

bentleyvk · 2026-07-09T12:08:12Z

Fixes #

Why

Using kimchi for day to day coding, so wanted to also use it inside Open Design so I could finally switch way from Claude Code.

What users will see

"Settings" -> "Execution mode" they will see kimchi CLI if they have it installed.

Surface area

UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
Keyboard shortcut — new or changed
CLI / env var — new od subcommand or flag, new tools-dev / tools-pack / tools-pr flag, or new OD_* env var
API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
Extension point — new entry under skills/, design-systems/, design-templates/, or craft/, or change to the skills protocol
i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope. Include a paragraph on what we get vs. what bytes we ship (see CONTRIBUTING.md → Code style)
Default behavior change — changes what existing users experience without opting in (default model, default setting, file/SQLite schema, auto-network on startup, auto-install)
None — internal refactor, docs, tests, or translation update only

Screenshots

Validation

Created a website prototype using kimchi
pnpm guard - passed
pnpm typecheck - passed
pnpm --filter @open-design/daemon test - passed

lefarcen

Hey @bentleyvk! 👋 Thanks for adding Kimchi as a new agent option.

Could you fill out the PR template before pool review? The body is currently empty except for the template comments. We need:

Why — what made you add Kimchi today? (Did you hit a use case where Kimchi was the right fit, or are you speculatively adding it for others?)
What users will see — "Settings → AI Providers now shows a new 'Kimchi' option" + where else the Kimchi icon/name appears (HandoffButton CLI dropdown, agent picker, etc.)
Surface area — tick UI (agent icon + picker) and New top-level dependency if this adds any new runtime dependency
Validation — what you ran (pnpm guard + pnpm typecheck + the relevant package tests)

The info helps pool review scope the change quickly.

PerishCode

Found one non-blocking docs consistency issue in the Kimchi adapter catalog. The runtime wiring itself follows the existing Pi RPC path I reviewed.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

github-actions · 2026-07-09T13:34:11Z

Visual regression review

Head: ac36111 · Base: c670485

0 changed · 53 unchanged · 0 new without baseline · 0 failed

Unchanged cases

Case	Main	PR	Diff
visual-avatar-local-agent-list _{0 px (0.00%)}
visual-avatar-local-agent-list-panel _{0 px (0.00%)}
visual-avatar-menu _{0 px (0.00%)}
visual-avatar-menu-panel _{0 px (0.00%)}
visual-avatar-open-design-account _{0 px (0.00%)}
visual-critical-settings _{0 px (0.00%)}
visual-critical-workspace _{0 px (0.00%)}
visual-critical-workspace-preview _{0 px (0.00%)}
visual-design-system-detail _{0 px (0.00%)}
visual-design-systems _{0 px (0.00%)}
visual-home _{209 px (0.02%)}
visual-home-catalog _{0 px (0.00%)}
visual-home-context-picker _{0 px (0.00%)}
visual-home-context-picker-popover _{0 px (0.00%)}
visual-home-plugin-filter _{0 px (0.00%)}
visual-home-plugin-use-staged _{0 px (0.00%)}
visual-home-plugin-use-with-query _{0 px (0.00%)}
visual-home-staged-attachment _{0 px (0.00%)}
visual-integrations _{0 px (0.00%)}
visual-integrations-mcp _{0 px (0.00%)}

Visual diff is advisory only and does not block merging.

lefarcen · 2026-07-09T13:36:58Z

🧪 This PR adds user-visible runtime/UI behavior, so it needs a manual QA pass before merge. Please hold off self-merging for now — once design/product sign-off is in and the PR is merge-ready, we'll queue QA here.

PerishCode

Found one non-blocking documentation mismatch after the latest Kimchi model-list fix. The runtime code now reads stdout and uses the updated fallback model id, but the adapter docs still describe the previous behavior.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

lefarcen · 2026-07-09T13:53:16Z

Hey @bentleyvk — PerishCode already caught the one follow-up I'd point to on this head: please align the Kimchi adapter docs with the runtime change so model discovery reads as stdout and the fallback model matches kimi-k2.7.

Once that docs note is updated, this head looks ready to keep moving through the design/QA gates.

bentleyvk · 2026-07-09T13:55:46Z

Hey @bentleyvk — PerishCode already caught the one follow-up I'd point to on this head: please align the Kimchi adapter docs with the runtime change so model discovery reads as stdout and the fallback model matches kimi-k2.7.

Once that docs note is updated, this head looks ready to keep moving through the design/QA gates.

Fixed comments

lefarcen · 2026-07-09T14:04:07Z

Thanks @bentleyvk — I checked the docs update on this head and the Kimchi note now matches the runtime change (stdout model discovery + kimi-k2.7 fallback).

No further bot follow-up from my side here; this can keep moving through the remaining design / QA gates once the pending checks finish.

bentleyvk · 2026-07-15T12:02:17Z

@lefarcen any news regarding review?

lefarcen · 2026-07-15T12:10:15Z

Hey @bentleyvk — I took another pass over the current head and I don't have a new bot follow-up beyond the docs fix that's already been addressed.

I re-requested review on this head and cleaned up the stale pending design label, since design is already signed off. The main thing still showing on GitHub right now is that the PR is in a merge-conflict state (CONFLICTING), so once it's rebased cleanly it should be in a much better spot for the final human review.

bentleyvk · 2026-07-16T05:55:28Z

Hey @bentleyvk — I took another pass over the current head and I don't have a new bot follow-up beyond the docs fix that's already been addressed.

I re-requested review on this head and cleaned up the stale pending design label, since design is already signed off. The main thing still showing on GitHub right now is that the PR is in a merge-conflict state (CONFLICTING), so once it's rebased cleanly it should be in a much better spot for the final human review.

@lefarcen Thanks, fixed it!

lefarcen · 2026-07-16T06:02:28Z

Thanks — the rebase looks clean now, and I don't see the earlier merge-conflict state anymore. From here it's just waiting on the pending human review for this head.

PerishCode · 2026-07-21T12:56:53Z

@bentleyvk I'm holding off on generating review comments for #5376 because this pull request has merge conflicts right now.

Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look.

_{🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos.}

PerishCode

The Kimchi runtime wiring is coherent with the existing Pi RPC path, but the new API-key override crosses the app-config secret boundary without the matching browser-side protection. This needs to be fixed before merge.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

Location: apps/daemon/src/app-config.ts RIGHT line 207

Treat KIMCHI_API_KEY as a secret across the full app-config path before allowing it here. This changed line makes the daemon accept and return the key in agentCliEnv, but apps/web/src/state/config.ts::AGENT_CLI_SECRET_ENV_KEYS does not include it, so sanitizeAgentCliEnv() can copy the credential into browser localStorage when config is persisted. The existing Claude/Codex keys are explicitly excluded there and are also tracked by the daemon/web auth-key sets; Kimchi currently bypasses those protections. Please either remove KIMCHI_API_KEY from this allowlist and rely on the daemon process environment/config file, or add it consistently to the daemon auth classification and web secret sanitizer (plus a regression test proving persisted web config omits it).

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

Inline comment could not be anchored: anchor_outside_complete_diff

feat: Adding kimchi CLI option

b978353

lefarcen requested a review from PerishCode July 9, 2026 12:11

lefarcen added size/XS PR changes <20 lines risk/medium Medium risk: regular code changes type/feature New feature needs-design-review Awaiting design review (external UI change); cleared by the Odcrew App applying design-approved labels Jul 9, 2026

lefarcen reviewed Jul 9, 2026

View reviewed changes

docs and rpc changed

f92cca6

bentleyvk marked this pull request as ready for review July 9, 2026 13:20

PerishCode reviewed Jul 9, 2026

View reviewed changes

Comment thread docs/agent-adapters.md Outdated

lefarcen added the needs-validation Runtime change detected; needs human or /explore agent validation. label Jul 9, 2026

vilkaz-cast added 2 commits July 9, 2026 16:38

docs fix

f7153e5

model list fix

59d1c6e

PerishCode reviewed Jul 9, 2026

View reviewed changes

Comment thread docs/agent-adapters.md Outdated

docs fix

460c8a3

open-design-crew Bot added the design-approved Design signed off (must be applied by the Odcrew App open-design-crew[bot]) label Jul 10, 2026

lefarcen removed the needs-design-review Awaiting design review (external UI change); cleared by the Odcrew App applying design-approved label Jul 15, 2026

lefarcen requested a review from PerishCode July 15, 2026 12:10

vilkaz-cast and others added 3 commits July 15, 2026 15:19

Merge remote-tracking branch 'origin/main' into vilius-kimchi-cli

5c47ca8

chore: trigger mergeability re-check

528be97

Merge branch 'main' into vilius-kimchi-cli

ac36111

lefarcen added needs-product-review Feature PR awaiting product sign-off before merge (see roadmap) size/M PR changes 100-300 lines and removed size/XS PR changes <20 lines labels Jul 21, 2026

Merge branch 'main' into vilius-kimchi-cli

88e903b

PerishCode requested changes Aug 3, 2026

View reviewed changes

Uh oh!

Conversation

bentleyvk commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What users will see

Surface area

Screenshots

Validation

Uh oh!

lefarcen left a comment

Choose a reason for hiding this comment

Uh oh!

PerishCode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual regression review

Uh oh!

lefarcen commented Jul 9, 2026

Uh oh!

PerishCode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lefarcen commented Jul 9, 2026

Uh oh!

bentleyvk commented Jul 9, 2026

Uh oh!

lefarcen commented Jul 9, 2026

Uh oh!

bentleyvk commented Jul 15, 2026

Uh oh!

lefarcen commented Jul 15, 2026

Uh oh!

bentleyvk commented Jul 16, 2026

Uh oh!

lefarcen commented Jul 16, 2026

Uh oh!

PerishCode commented Jul 21, 2026

Uh oh!

PerishCode left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bentleyvk commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading