test: port PR 6229 acceptance coverage to main - #6272
Conversation
Replace replay timing sleep with persisted checkpoint polling and allow the multi-process lifecycle test enough time for startup and cleanup. Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
|
The coverage port itself is clear from the diff, but the PR body still needs a bit more review context before pool review picks it up. Could you add a short why section, a brief "what users will see" note (even if the answer is "no user-visible change; test coverage only"), and the surface-area checklist so it is obvious why these acceptance cases moved from #6229 onto main? |
nettee
left a comment
There was a problem hiding this comment.
Found 2 non-blocking issues in the new manual-edit acceptance coverage that are worth tightening before relying on these cases as regression signal.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.Use the platform shortcut modifier for browser copy/paste and target the distinct inserted image before deletion so the structural tests verify the correct node.\n\nGenerated-By: looper 0.11.3 (runner=fixer, agent=codex)
|
Looper fixer round complete — 3cd8b59
🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos. |
nettee
left a comment
There was a problem hiding this comment.
@AmyShang-alt I reviewed the changed ranges for the ported acceptance coverage across daemon restart reconciliation, telemetry/langfuse crash-window handling, AMR/service-error smoke flows, packaged updater floor routing, and the manual-edit history/clipboard cases. The assertions line up with the current implementation, and the earlier manual-edit follow-up fixes are present on this head. Nice job carrying this stack onto main cleanly.
What changed
Port the incremental acceptance coverage from PR #6229 onto the current
mainbranch after its original stacked base branch was superseded by PR #6150.Validation
git diff --checkpassed.