Skip to content

test: port PR 6229 acceptance coverage to main - #6272

Open
AmyShang-alt wants to merge 6 commits into
mainfrom
agent/6229-to-main
Open

test: port PR 6229 acceptance coverage to main#6272
AmyShang-alt wants to merge 6 commits into
mainfrom
agent/6229-to-main

Conversation

@AmyShang-alt

Copy link
Copy Markdown
Contributor

What changed

Port the incremental acceptance coverage from PR #6229 onto the current main branch after its original stacked base branch was superseded by PR #6150.

  • Add daemon process-restart reconciliation coverage.
  • Add telemetry checkpoint/crash-window and ACP usage coverage.
  • Add Anthropic BYOK URL normalization cases.
  • Add service-error, AMR, packaged-updater, and Manual Edit E2E coverage.

Validation

  • Targeted daemon reconciliation and telemetry tests passed.
  • git diff --check passed.
  • Typecheck was attempted; the current main workspace has pre-existing contracts/dist export mismatches unrelated to this port.

Replace replay timing sleep with persisted checkpoint polling and allow the multi-process lifecycle test enough time for startup and cleanup.

Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
Generated-By: looper 0.11.3 (runner=fixer, agent=codex)
@lefarcen
lefarcen requested a review from nettee July 30, 2026 06:43
@lefarcen lefarcen added size/XL PR changes 700-1500 lines risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps type/chore CI / build / config / tooling skip-validation Maintainer override: bot will not auto-add needs-validation on this PR. labels Jul 30, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

The coverage port itself is clear from the diff, but the PR body still needs a bit more review context before pool review picks it up. Could you add a short why section, a brief "what users will see" note (even if the answer is "no user-visible change; test coverage only"), and the surface-area checklist so it is obvious why these acceptance cases moved from #6229 onto main?

@nettee nettee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 non-blocking issues in the new manual-edit acceptance coverage that are worth tightening before relying on these cases as regression signal.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Comment thread e2e/ui/app-manual-edit.test.ts Outdated
Comment thread e2e/ui/app-manual-edit.test.ts
Use the platform shortcut modifier for browser copy/paste and target the distinct inserted image before deletion so the structural tests verify the correct node.\n\nGenerated-By: looper 0.11.3 (runner=fixer, agent=codex)
@AmyShang-alt

Copy link
Copy Markdown
Contributor Author

Looper fixer round complete3cd8b59

  • ✅ Review comment on e2e/ui/app-manual-edit.test.ts (@nettee) — thread
    • Added a platform-aware Meta/Control shortcut modifier for copy and paste in e2e/ui/app-manual-edit.test.ts.
  • ✅ Review comment on e2e/ui/app-manual-edit.test.ts:376 (@nettee) — thread
    • The tests now select the second inserted image, assert the original is not selected, then verify deletion leaves the original node.

🔁 Powered by Looper · runner=fixer · agent=codex · An autonomous AI dev team for your GitHub repos.

@lefarcen
lefarcen requested a review from nettee July 30, 2026 07:01

@nettee nettee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmyShang-alt I reviewed the changed ranges for the ported acceptance coverage across daemon restart reconciliation, telemetry/langfuse crash-window handling, AMR/service-error smoke flows, packaged updater floor routing, and the manual-edit history/clipboard cases. The assertions line up with the current implementation, and the earlier manual-edit follow-up fixes are present on this head. Nice job carrying this stack onto main cleanly.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps size/XL PR changes 700-1500 lines skip-validation Maintainer override: bot will not auto-add needs-validation on this PR. type/chore CI / build / config / tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants