fix(workspace): stop retracted Team plugins immediately

[lefarcen]

Why

While validating Workspace Team resource synchronization, we found that plugins were the only shared resource kind not connected to the existing reconciliation path. A plugin pulled by a teammate could therefore remain readable and applicable in an already-open daemon after the owner retracted it. Hub push notifications, reconnect catch-up, and the polling fallback all ran, but there was no persisted Team-plugin binding for them to retire.

This is a correctness and authorization problem: a remote retraction must invalidate the exact Workspace-scoped Team mirror without relying on the daemon's mutable current/default Workspace. The fix must also preserve valid Personal and Team plugins that share the same manifest ID.

Merge sequencing: keep this PR open until #6312 has merged, then rebase/update and revalidate the current head before merge.

What users will see

When a teammate retracts a shared Team plugin, an already-open Open Design session stops listing, reading, or applying that Team copy after the next hub push, reconnect catch-up, or polling pass. A same-ID Personal plugin remains available. Existing pre-binding Team plugin materializations are adopted without disappearing during upgrade.

No UI controls or copy change.

Surface area

• UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
• Keyboard shortcut — new or changed
• CLI / env var — new od subcommand or flag, new tools-dev / tools-pack flag, or new OD_* env var
• API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
• Extension point — new entry under skills/, design-systems/, design-templates/, or craft/, or change to the skills protocol
• i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
• New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope. Include a paragraph on what we get vs. what bytes we ship (see CONTRIBUTING.md → Code style)
• Default behavior change — changes what existing users experience without opting in (default model, default setting, file/SQLite schema, auto-network on startup, auto-install)
• None — internal refactor, docs, tests, or translation update only

Screenshots

Not applicable: this is daemon-side reconciliation and authorization behavior with no UI changes.

Bug fix verification

• Test paths: apps/daemon/tests/plugins-workspace-scope.test.ts, apps/daemon/tests/plugins-apply-workspace-retraction.test.ts, apps/daemon/tests/team-resource-share-list-cache.test.ts
• Red/green evidence on the target branch (origin/feat/workspace-team):
  • Retraction red spec failed with expected ['plugin-retracted'] to not include 'plugin-retracted' before the source fix.
  • Personal/Team same-ID collision red spec failed with expected [] to include 'plugin-collision' before Team mirror bindings were namespaced.
  • Deferred retraction race red spec failed with expected { id: 'plugin-concurrent-retraction' } to be null before the post-resolve authorization check.
  • Deferred activation race failed with expected true to be false before the post-resolution authoritative shared check.
  • Route-level deferred apply race returned HTTP 200 and invoked applyPlugin before the final exact-binding gate; it now returns 404 without invoking apply.
  • Deferred old-listing matrix failed for both versioned and unversioned materializations (expected true to be false) before both cached fast paths gained their final authoritative shared check.
  • Primed outer /api/workspace/plugins/team cache kept returning plugin-retracted after the remote list became empty and background invalidation ran; the immediate next read is now empty.
  • All eight are green on this branch.
• main is not the applicable red baseline because this work targets the in-progress Workspace Team implementation on feat/workspace-team; the tests were run red against the requested target branch before applying the fix.

Validation

• pnpm --filter @open-design/daemon exec vitest run tests/plugins-workspace-scope.test.ts tests/plugins-apply-workspace-retraction.test.ts tests/team-resource-share.test.ts tests/team-resource-share-list-cache.test.ts tests/collab/workspace-resources-reconciler.test.ts tests/collab/team-resource-materialization.test.ts tests/plugin-asset-workspace-authority.test.ts tests/plugins-uninstall-workspace-gate.test.ts — 8 files, 71 tests passed
• pnpm --filter @open-design/daemon typecheck
• pnpm --filter @open-design/daemon build
• pnpm guard
• git diff --check

The broader daemon suite was also sampled earlier. It was stopped after unrelated existing failures in tests/mcp-runs.test.ts and tests/run-create-workspace-gate.test.ts plus MaxListenersExceededWarning; the focused Workspace Team/plugin lane above is green.

[mrcfps]

@lefarcen Thank you for tightening the Team-plugin retraction path and preserving Personal/Team same-ID behavior. The binding namespace and post-resolution read check are solid building blocks, but two remaining async windows can still reactivate or apply a plugin after reconciliation has retired it. These are authorization-path races that should be closed before merge.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

[mrcfps]

@lefarcen Thank you for closing the previously reported resolution and apply races—the final binding gates and focused regression coverage are valuable improvements. One remaining stale-list fast path can still reactivate a Team plugin after fresh reconciliation has retired it, so the immediate-retraction guarantee is not yet complete.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

[mrcfps]

@lefarcen Thank you for carefully closing the earlier activation and apply races and adding focused regression coverage. Those fixes are solid, and the focused 69-test lane, daemon typecheck, and repository guard all pass locally. One remaining cache-layer gap still lets the Team collection serve a retracted plugin after background reconciliation, so the primary immediate-listing guarantee needs one more fix before merge.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

[mrcfps]

@lefarcen I verified the Workspace-scoped Team-plugin binding lifecycle, the post-resolution read/apply gates, the versioned and unversioned stale-list activation fences, and the new invalidation of both Team-list cache layers before background reconciliation. Personal plugins with the same manifest ID remain independent, and legacy Team materializations are adopted without losing retraction coverage. The focused 71-test daemon matrix, daemon build/typecheck, repository guard, and full workspace typecheck all pass locally. Thank you for the careful follow-through on the concurrency cases and for the strong regression coverage—this is a solid fix. 🙏

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

[mrcfps]

@lefarcen Thank you for the careful rebase and for preserving the focused retraction coverage. The 71-test daemon lane, daemon typecheck, and repository guard pass on this head. I found one remaining out-of-order activation race and am leaving it as a non-blocking follow-up under the review cap; a maintainer should confirm whether to close it before merge.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

[mrcfps]

@lefarcen I verified the Workspace-scoped Team-plugin binding lifecycle, legacy materialization adoption, exact post-resolution read/apply gates, two-layer Team-list cache invalidation, and the new generation fence that prevents an older positive hub read from overwriting a newer tombstone. Personal plugins with the same manifest ID remain independent. The focused daemon matrix (8 files, 72 tests), changed Playwright case, daemon build/typecheck, e2e typecheck, repository guard, full workspace typecheck, and diff check all pass locally. Thank you for the careful follow-through on the concurrency feedback and the strong deterministic regression coverage—this is a solid fix. 🙏

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}