Skip to content

fix(dsh-runtime): add prepare script so git installs build dist #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedantMadane wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

fix(dsh-runtime): add prepare script so git installs build dist #7475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dsh-runtime/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
}
},
"scripts": {
"prepare": "pnpm run build",

@PerishCode PerishCode Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using prepare on this package while it is consumed from a subdirectory of the monorepo. With pnpm 10.33.2, an exact install of github:nexu-io/open-design#84c90101165ab75081d36b67dde4d8e00d865d8d&path:packages/dsh-runtime first fails unless the consumer allowlists this script; after allowlisting it, pnpm runs pnpm install against the fetched repository workspace. The reproduction selected all 29 workspace projects and installed 1,292 packages, then ran unrelated native postinstalls including onnxruntime-node; the runtime build had still not started after several minutes. This turns a small plugin dependency into a full repository/native-toolchain installation, so it can fail on the same constrained consumer environments this PR is intended to fix and executes much more third-party install code than the package requires. Please ship a self-contained prebuilt package instead (for example, publish/consume the existing packed artifact with dist, or provide an equivalent repository artifact that does not need a git prepare), and add an install-level regression that imports both the root and ./startup exports from that artifact.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

"build": "tsx ./clean.ts && tsx ./esbuild.config.ts && tsc -p tsconfig.json --emitDeclarationOnly",
"test": "vitest run",
"typecheck": "tsc -p tsconfig.json --noEmit && tsc -p tsconfig.tests.json --noEmit"
Expand Down
Loading