Skip to content

fix(landing): keep reveal content visible without JavaScript - #7502

Open
open-design-crew[bot] wants to merge 5 commits into
mainfrom
fix/homepage-reveal-progressive-enhancement
Open

fix(landing): keep reveal content visible without JavaScript#7502
open-design-crew[bot] wants to merge 5 commits into
mainfrom
fix/homepage-reveal-progressive-enhancement

Conversation

@open-design-crew

Copy link
Copy Markdown
Contributor

Summary

  • Keep homepage reveal content visible in the initial HTML/CSS state when JavaScript is unavailable or fails.
  • Preserve the existing reveal animation by applying hidden start states only after the observer is successfully initialized.
  • Add regression tests for the progressive-enhancement contract.

Problem

Homepage copy was server-rendered but hidden by default with opacity: 0 and only revealed after JavaScript ran. If the script failed or never executed, users and crawlers could receive the text but not see it.

Solution

Content is now visible by default. JavaScript creates and attaches the existing IntersectionObserver first, then adds the reveal-ready class that enables the unchanged animation start states. If initialization fails, the class is removed and the content stays visible.

Validation

  • Focused progressive-enhancement tests: 3/3 passed.
  • Astro typecheck: 0 errors.
  • Landing-page test/build: 244/244 tests passed and 6,740 pages built.
  • Desktop and mobile browser QA: reveal animation still runs; visible content does not remain hidden; no console errors or horizontal overflow.

Risk

Low and scoped to homepage reveal initialization and CSS gating. Animation timings, easing, transforms, and observer behavior are unchanged.

Related

Replaces closed PR #7498, which could not enter CI because it was created by an account with Actions disabled.

@open-design-crew
open-design-crew Bot requested review from mrcfps and nettee August 27, 2026 10:08
@lefarcen lefarcen added size/M PR changes 100-300 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix labels Aug 27, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

Quick body nit: the Summary / Problem / Solution sections already make the fix clear.

Could you add the Surface area checklist too, even if it's just None, so the template is complete for the next reviewer?

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

🚀 Landing page preview

This PR is deployed to a Cloudflare Pages preview — not staging or production:

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening the homepage’s progressive-enhancement behavior. The observer setup and failure fallback are thoughtfully scoped, and the focused contract test passes. I found two non-blocking CSS/template consistency issues worth addressing so the existing animation exceptions and canonical example stay aligned.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Comment thread apps/landing-page/app/globals.css
Comment thread apps/landing-page/app/globals.css
@open-design-crew
open-design-crew Bot requested a review from mrcfps August 27, 2026 10:19

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @app/open-design-crew for addressing the earlier reveal-specificity and template-parity feedback—the homepage behavior is now well scoped, and the focused regression cases pass. I found one non-blocking source-of-truth gap in the reusable template generator that should be fixed so this improvement survives regeneration.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Comment thread design-templates/open-design-landing/example.html
@lefarcen lefarcen added the needs-validation Runtime change detected; needs human or /explore agent validation. label Aug 27, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

Adding needs-validation so this doesn’t get merged before a manual QA pass.

One body follow-up as well: could you fill in the Surface area checklist and the bug-fix verification section? The Summary / Problem / Solution write-up is already clear, so those two additions should make the template complete for the next pass.

@open-design-crew
open-design-crew Bot requested a review from mrcfps August 27, 2026 10:30

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @app/open-design-crew for following through on the earlier reveal-specificity and template-generator feedback. The current head keeps content visible by default, gates the existing motion behind successful observer binding, and preserves the hero/mobile exceptions; the focused regression tests, landing-page typecheck, and repository guard all pass. I found one non-blocking test-ownership cleanup so the new cross-surface contract stays in the repository's intended validation lane.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

Comment thread apps/landing-page/tests/home-reveal-progressive-enhancement.test.ts Outdated
@open-design-crew
open-design-crew Bot requested a review from mrcfps August 27, 2026 10:43

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@app/open-design-crew

Thanks for carefully carrying this progressive-enhancement fix through the homepage, canonical template, generator inputs, and the correct cross-resource test lane. I verified that reveal content is visible by default, hidden states are enabled only after observer binding succeeds, initialization failures fail open, and the hero/mobile exceptions retain their intended cascade behavior. The focused landing and e2e regression tests pass, landing-page typecheck reports zero errors, the repository guard passes, and the live landing validation check is green. Nice follow-through on the earlier review feedback. 🙌

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@lefarcen
lefarcen requested a review from AmyShang-alt August 27, 2026 10:59

@nettee nettee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@app/open-design-crew

I reviewed every changed range across the homepage enhancer, reveal CSS, canonical template inputs/example, and the landing parity tests. The focused landing tests, Astro typecheck, e2e parity test/typecheck, static build, and desktop/mobile plus JavaScript-disabled and failing-observer smoke checks all pass; the readiness gate and animation exceptions remain aligned. Thanks for the careful follow-through on the earlier feedback and for adding regression coverage—nice work! 🙌

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@AmyShang-alt
AmyShang-alt removed this pull request from the merge queue due to a manual request Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-validation Runtime change detected; needs human or /explore agent validation. risk/medium Medium risk: regular code changes size/M PR changes 100-300 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants