-
Notifications
You must be signed in to change notification settings - Fork 4
Add Operation-Timeout header definition #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SPEC.md
Outdated
@@ -275,6 +275,14 @@ a response. | |||
Format of this header value is number + unit, where unit can be `ms` for milliseconds, `s` for seconds, and `m` for | |||
minutes. | |||
|
|||
### `Operation-Timeout` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is just for StartOperation, you should put this on the request headers section for that RPC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also clarify the difference between this and Request-Timeout
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah how is the SDK supposed to treat Request-Timeout
vs Operation-Timeout
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added another line about Request-Timeout
vs Operation-Timeout
LMK if that's more clear
SPEC.md
Outdated
@@ -275,6 +275,14 @@ a response. | |||
Format of this header value is number + unit, where unit can be `ms` for milliseconds, `s` for seconds, and `m` for | |||
minutes. | |||
|
|||
### `Operation-Timeout` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about https://http.dev/prefer. We could probably add our own preference on this header if we wanted (though don't think we can reuse wait
as defined at https://www.rfc-editor.org/rfc/rfc7240.html#section-4.3 because it is the same as request timeout).
But it's not really a standard (now, if ever), so maybe not. It is used sometimes, e.g. https://docs.postgrest.org/en/v12/references/api/preferences.html.
Adding a new predefined
Operation-Timeout
header