Skip to content

Clarify Failure details needs to be JSON serializable. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Clarify Failure details needs to be JSON serializable. #13

merged 1 commit into from
Dec 19, 2024

Conversation

bergundy
Copy link
Contributor

It can be assumed because of the JSON schema any type, but this will remove any chance for confusion.

Sushisource
Sushisource approved these changes Dec 19, 2024
View reviewed changes
Copy link

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The grpc comment is really the place it'd help the most, since that's just bytes.

Sushisource
Sushisource approved these changes Dec 19, 2024
View reviewed changes
Copy link

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, wrong button.

@bergundy bergundy merged commit 94d950f into main Dec 19, 2024
1 check passed
@bergundy bergundy deleted the clarify-failure-details-jsonable branch December 19, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@pdoerner pdoerner pdoerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bergundy @Sushisource @pdoerner