Skip to content

Downgrade Go to 1.23 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bergundy merged 1 commit into from
Oct 15, 2025
Merged

Downgrade Go to 1.23 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
submodules: recursive
- uses: actions/setup-go@v4
with:
go-version: "1.25"
go-version: "1.23"
- name: Lint
uses: golangci/golangci-lint-action@v8
with:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/nexus-rpc/sdk-go

go 1.25
go 1.23

require github.com/stretchr/testify v1.8.4

Expand Down
4 changes: 2 additions & 2 deletions nexus/operation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func startOperation(
options StartOperationOptions,
) (HandlerStartOperationResult[any], error) {
t.Helper()
ctx := WithHandlerContext(t.Context(), HandlerInfo{
ctx := WithHandlerContext(context.Background(), HandlerInfo{
Service: svc.Name,
Operation: op.Name(),
Header: options.Header,
Expand All @@ -96,7 +96,7 @@ func cancelOperation(
options CancelOperationOptions,
) error {
t.Helper()
ctx := WithHandlerContext(t.Context(), HandlerInfo{
ctx := WithHandlerContext(context.Background(), HandlerInfo{
Service: svc.Name,
Operation: op.Name(),
Header: options.Header,
Expand Down