chore: mark old updater test script as deprecated#2076
Open
ev0r0x wants to merge 1 commit intonexus-xyz:mainfrom
Open
chore: mark old updater test script as deprecated#2076ev0r0x wants to merge 1 commit intonexus-xyz:mainfrom
ev0r0x wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The test script
tests/test_updater.shrelied on an old auto-update mechanism that no longer exists.This includes the
--updater-mode testflag and files like.prover.pidand.current_version.To prevent confusion, the script is now explicitly marked as DEPRECATED at the top:
Why
Leaving the script unmarked could mislead developers into thinking the auto-update is still tested by this script.
This change keeps the history but clearly signals that it shouldn’t be run.
Notes
but it was decided to simply add a description.