fix: Add overflow protection to Fibonacci implementation#371
fix: Add overflow protection to Fibonacci implementation#371sjudson merged 3 commits intonexus-xyz:mainfrom
Conversation
* WIP * add benchmarking * fmt * fix * x * Update tests/testing-framework/src/emulator.rs Co-authored-by: duc-nx <duc@nexus.xyz> * comments + wrapper function for serialization/assertions * fix * Update tests/testing-framework/Cargo.toml Co-authored-by: Ben Hoberman <bhoberman@users.noreply.github.com> * Update .gitignore Co-authored-by: Ben Hoberman <bhoberman@users.noreply.github.com> * rebase fix * fix test * fmt * fmt * fix * fix * x * harvard * revise --------- Co-authored-by: duc-nx <duc@nexus.xyz> Co-authored-by: Ben Hoberman <bhoberman@users.noreply.github.com>
|
@DeVikingMark Thanks for the fixes. As part of our new licensing, we require signing a contributor license agreement in order to contribute to the the codebase. If you rebase this PR off |
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
@sjudson yeah sure, I signed it |
sjudson
left a comment
There was a problem hiding this comment.
Retracting my review, seems like the tests that use this program are now failing.
@sjudson May I ask you to have a look at it now? I suppose it should be fine, but if it's not, I'll try to seek deeper the problem |
Description:
It prevents potential integer overflow vulnerabilities in the zkVM test suite while maintaining backwards compatibility.