Skip to content

fix: Add overflow protection to Fibonacci implementation #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjudson merged 3 commits into from
Apr 2, 2025
Merged

fix: Add overflow protection to Fibonacci implementation #371

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e952c76
Update fib.rs
DeVikingMark Mar 13, 2025
1e36f25
Merge branch 'nexus-xyz:main' into fib-rs
DeVikingMark Apr 2, 2025
257f1c5
Update fib.rs
DeVikingMark Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions tests/integration-tests/fib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,26 @@
#[nexus_rt::main]
#[nexus_rt::public_input(n)]
fn main(n: u32) -> u32 {
let mut a = 0;
let mut b = 1;

// Handle edge cases
if n == 0 {
return a;
return 0;
}
if n == 1 {
return 1;
}

for _ in 2..n {
let c = a + b;
let mut a = 0u32;
let mut b = 1u32;

for _ in 2..=n {
// Check for potential overflow before addition
if let Some(c) = a.checked_add(b) {
a = b;
b = c;
b = c;
} else {
// In case of overflow, return max value
return u32::MAX;
}
}

b
Expand Down