Merged
Conversation
Contributor
|
@youyyytrok Thanks for the fixes. As part of our new licensing, we require signing a contributor license agreement in order to contribute to the the codebase. If you rebase this PR off |
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Hi @sjudson! Done. |
sjudson
suggested changes
Mar 28, 2025
Contributor
sjudson
left a comment
sjudson
left a comment
There was a problem hiding this comment.
Minor, but otherwise LGTM.
runtime/README.md
Outdated
|
|
||
| To see more, such as how to introduce program i/o, precompiles, | ||
| and native compilation support, check out our [documentation](docs.nexus.xyz). | ||
| and native compilation support, check out our [documentation](https://docs.nexus.xyz). |
Contributor
There was a problem hiding this comment.
Would you be able to align this with the main repo readme, which points to https://docs.nexus.xyz/zkvm/index?
sjudson
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this resolving a feature or a bug?
Hi! I resolves bugs related to broken links and improves the overall quality of the documentation by ensuring all links are functional and properly formatted.
Are there existing issue(s) that this PR would close?
If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.
Describe your changes.
runtime/README.md:vm/src/riscv/instructions/instruction.rs: