fix: validation for main function signature#387
Closed
0xbryer wants to merge 1 commit intonexus-xyz:mainfrom
Closed
fix: validation for main function signature#3870xbryer wants to merge 1 commit intonexus-xyz:mainfrom
main function signature#3870xbryer wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
slumber
requested changes
Apr 7, 2025
Contributor
slumber
left a comment
slumber
left a comment
There was a problem hiding this comment.
Thank you for the PR. Feel free to elaborate on your changes and reopen it.
| if !func.sig.inputs.is_empty() { | ||
| return Err(Error::new_spanned( | ||
| &fn_sig.inputs, | ||
| &func.sig.inputs, |
|
|
||
| Ok(quote! { | ||
| const _: fn() = main; | ||
| const _: fn() = ::std::main; |
Contributor
There was a problem hiding this comment.
This constant is supposed to check the type of the main function, e.g. against extern and presence of return value.
Therefore I don't follow this change
chuckyLeeVIII
pushed a commit
to chuckyLeeVIII/nexus-zkvm
that referenced
this pull request
Apr 18, 2025
Summary: Fix nexus-xyz#387 Test Plan: Co-authored-by: duc-nx <>
sjudson
pushed a commit
that referenced
this pull request
May 14, 2025
Summary: Fix #387 Test Plan: Co-authored-by: duc-nx <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes.
i made a few fixes to the validation logic for the
mainfunction.specifically:
ReturnType::Defaultinstead of incorrectly checking forReturnType::Type.func.sig.inputsinstead offn_sig.inputs.quote!macro to properly reference::std::main, ensuring the correct function path.