fix: handle PRECOMPILE_COUNT symbol in ELF parser#474
Open
avorylli wants to merge 4 commits intonexus-xyz:mainfrom
Open
fix: handle PRECOMPILE_COUNT symbol in ELF parser#474avorylli wants to merge 4 commits intonexus-xyz:mainfrom
avorylli wants to merge 4 commits intonexus-xyz:mainfrom
Conversation
Contributor
|
@avorylli tests are failing |
Contributor
Author
Contributor
|
Going to leave this pending since the precompile work is still in an intermediary state, and we may not want to skip this symbol but use it in another way. |
SashaMalysehko
pushed a commit
to SashaMalysehko/nexus-zkvm
that referenced
this pull request
Dec 9, 2025
Summary: Fixes nexus-xyz#452 Test Plan: Co-authored-by: duc-nx <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ELF parser to skip PRECOMPILE_COUNT symbol when parsing precompile metadata.
The parser was failing when encountering non-numeric precompile symbols like PRECOMPILE_COUNT.
Also correct test expectations to match actual file content.