Skip to content

feat: Optimize View::view_public_input to avoid temporary Vec allocation #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VolodymyrBg wants to merge 1 commit into from
Closed

feat: Optimize View::view_public_input to avoid temporary Vec allocation #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions vm/src/emulator/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,18 +268,16 @@ impl View {
pub fn view_public_input(&self) -> Option<Vec<u8>> {
// we need to carefully skip the input length
self.memory_layout.map(|layout| {
io_entries_into_vec(
layout.public_input_start() + WORD_SIZE as u32,
self.input_memory
.iter()
.filter(|entry: &&MemoryInitializationEntry| {
layout.public_input_start() + WORD_SIZE as u32 <= entry.address
&& entry.address < layout.public_input_end()
})
.copied()
.collect::<Vec<_>>()
.as_slice(),
)
let start = layout.public_input_start() + WORD_SIZE as u32;
let end = layout.public_input_end();
let mut out = vec![0u8; (end - start) as usize];
self.input_memory.iter().for_each(|entry| {
if entry.address >= start && entry.address < end {
let idx = (entry.address - start) as usize;
out[idx] = entry.value;
}
});
out
})
}

Expand Down